Eclipse compile plugin fails to copy files containing warnings (PATCH for bug + upgrade to JDT 3.4.2)

The Eclipse compile plugin fails to copy files containing warnings to the target directory.

The attached patch against the latest SVN as of today (2008-12-03) corrects this problem and in addition updates the compiler plugin to the Eclipse 3.4.2.v_883_R34x JDT drawn from the JBoss Maven 2 repository - in contrast to some other patches here, there is no need to install that plugin locally.

Having a working Eclipse compiler plugin for Maven is very important, because the Sun Java compiler is flawed. E.g. it does not support when a method in class A returns type RETA and the derived class B returns RETB which is derived from RETA. There also seem to be issues when generics are extensively used. The Eclipse JDTs resolve this just fine. People developing in Eclipse will not notice these problems unless they try to build their code with Maven and are then quite barred from migrating to Maven if they do not want to adapt their code, since the current Eclipse compile plugin has that problem with warnings.