PicoContainer

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8
• Fix Version/s: 2.9
• Component/s: PicoContainer (Java)
• Labels:

  None

The following code throws a NullPointerException

public static class TestStartable implements org.picocontainer.Startable {
		@Override
		public void start() {
			// empty
		}

		@Override
		public void stop() {
			// empty
		}
	}
	
	@Test
	public void testIsStartedShouldNotThrowOnNonStartedComponent() {
		DefaultPicoContainer cont = new DefaultPicoContainer();
		cont.as(CACHE).addComponent(TestStartable.class);
		ComponentAdapter<?> adapter = cont.getComponentAdapter(TestStartable.class);
		Cached cached = adapter.findAdapterOfType(Cached.class);

               // this line throws - instead of returning false
		assertFalse(cached.isStarted());
	}

This is caused by the instance not being cached yet (instanceReference.get() == null), and hence the .started member cannot be accessed.

Suggest to fix by changing RealComponentLifecycle<T>.isStarted() to (this is the 'patch')

public boolean isStarted() {
            // add this guardInstRef() line
            guardInstRef();
            return instanceReference.get().started;
        }

• Assignee:

  Paul Hammant

  Reporter:

  Mark J. Sinke

• Created:

  12/May/09 2:28 AM

  Updated:

  12/May/09 6:59 AM

  Resolved:

  12/May/09 6:59 AM