PicoContainer

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8
• Fix Version/s: 2.9
• Component/s: PicoContainer (Java)
• Labels:

  None
• Environment:

  Java 1.6 on Windows XP (but that's really irrelevant here)

AbstractAdapter.findComponentAdapterOfType implements wrongly as

if (this.getClass().isAssignableFrom(componentAdapterType)) {
    		return (U) this;
    	} else if (getDelegate() !=  null) {
    		return getDelegate().findAdapterOfType(componentAdapterType);
    	}
        return null;

but AbstractBehavior implements this as

if (componentAdapterType.isAssignableFrom(this.getClass())) {
            return (U) this;
        // next else block is superfluous
        } else if (componentAdapterType.isAssignableFrom(delegate.getClass())) {
            return (U) delegate;
        } else {
            return delegate.findAdapterOfType(componentAdapterType);
        }

The first clause is reversed with respect to between the two constructs. In addition, the Behavior implementation's marked else clause is superfluous.

The junit test code below makes the difference stand out

public static class Foo {
		public Foo() {
			// empty
		}
	}
	
	// This test fails
	@Test
	public void testShouldFindSupertypeOfAdapterOnAbstractAdapterDerivative() {
		ConstructorInjector<Foo> injector = new ConstructorInjector<Foo>("key", Foo.class);
		assertSame(injector, injector.findAdapterOfType(SingleMemberInjector.class));
	}

	// This test works
	@Test
	public void testShouldFindSupertypeOfAdapterOnAbstractBehaviorDerivative() {
		ConstructorInjector<Foo> injector = new ConstructorInjector<Foo>("key", Foo.class);
		Cached<Foo> adapter = new Cached<Foo>(injector);
		assertSame(adapter, adapter.findAdapterOfType(Stored.class));
		assertSame(injector, adapter.findAdapterOfType(SingleMemberInjector.class));
	}

I suggest to align the AbstractAdapter implementation with Behavior's in this way

if (adapterType.isAssignableFrom(this.getClass())) {
    		return (U) this;
    	} else if (getDelegate() !=  null) {
    		return getDelegate().findAdapterOfType(componentAdapterType);
    	}
        return null;

and to simplify Behavior's implementation to

if (componentAdapterType.isAssignableFrom(this.getClass())) {
            return (U) this;
        } else {
            return delegate.findAdapterOfType(componentAdapterType);
        }

• Assignee:

  Paul Hammant

  Reporter:

  Mark J. Sinke

• Created:

  08/May/09 9:57 AM

  Updated:

  12/May/09 7:11 AM

  Resolved:

  12/May/09 7:11 AM