Alternate ComponentAdapter Implementation which is more flexible

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 2.0
  • Fix Version/s: 2.2
  • Component/s: PicoContainer (Java)
  • Labels:
    None

Description

Hey Folks,

as you might know I've been on a custom PicoContainer for quite some time and learned quite a few things in my time there. This is the first step I'd like to take in direction of Pico2.0.

Explanation follows on mailing list.

  1. GZip Archive
    pico.tar.gz
    16/Oct/04 10:52 AM
    4 kB
    Thomas Heller
  2. GZip Archive
    pico2.tar.gz
    17/Oct/04 9:01 AM
    5 kB
    Thomas Heller

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Thomas Heller added a comment -

Sample Implementation for CDI and Singleton caching only.

Show
Thomas Heller added a comment - Sample Implementation for CDI and Singleton caching only.
Hide
Permalink
Thomas Heller added a comment -

Added Lifecycle changes, see mailing list for explanation.

Show
Thomas Heller added a comment - Added Lifecycle changes, see mailing list for explanation.
Hide
Permalink
Joerg Schaible added a comment -

Pointer to original thread: http://thread.gmane.org/gmane.comp.java.picocontainer.devel/3889

Show
Joerg Schaible added a comment - Pointer to original thread: http://thread.gmane.org/gmane.comp.java.picocontainer.devel/3889
Hide
Permalink
Michael Rimov added a comment -

Ok, I like this much better. The only thing is that we need a way to be able to actually get the to the Features for customization, modification.

Aside from the fact that there's a Java 5 generic reference in the default component adapter, I don't see anything that would prevent this from being able to be merged into the Pico code base today.

Instead of calling it DefaultComponentAdapter, we could call it FeatureComponentAdapter or something like that. (You guys are always better with the names!) Create a component adapter factory for this with the appropriate modifications.

Then by bringing feature implementations along-side it, we could have a migration path. HotSwapFeature, JMXFeature ....

I'm sorry if there's some ignorance going on here – I tried pulling up the original thread link but got timeouts trying to connect – but am I missing something?

-Mike (R)

Show
Michael Rimov added a comment - Ok, I like this much better. The only thing is that we need a way to be able to actually get the to the Features for customization, modification. Aside from the fact that there's a Java 5 generic reference in the default component adapter, I don't see anything that would prevent this from being able to be merged into the Pico code base today. Instead of calling it DefaultComponentAdapter, we could call it FeatureComponentAdapter or something like that. (You guys are always better with the names!) Create a component adapter factory for this with the appropriate modifications. Then by bringing feature implementations along-side it, we could have a migration path. HotSwapFeature, JMXFeature .... I'm sorry if there's some ignorance going on here – I tried pulling up the original thread link but got timeouts trying to connect – but am I missing something? -Mike (R)
Hide
Permalink
Michael Rimov added a comment -

I'm closing this issue because I believe Paul addressed it in version 2.0 ComponentAdapter and ComponentAdapterFactory implementations.

Reopen if I'm wrong

Show
Michael Rimov added a comment - I'm closing this issue because I believe Paul addressed it in version 2.0 ComponentAdapter and ComponentAdapterFactory implementations. Reopen if I'm wrong
Hide
Permalink
Paul Hammant added a comment -

We've done a lot in the same direction as Thomas outlined. Especially the naming changes.

addFeature(..) we did not do
Pico3 perhaps.

  • Paul
Show
Paul Hammant added a comment - We've done a lot in the same direction as Thomas outlined. Especially the naming changes. addFeature(..) we did not do Pico3 perhaps.
  • Paul

People

  • Assignee:
    Unassigned
    Reporter:
    Thomas Heller
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: