[#PICO-205] greedy non-public constructors are prefered over public constructors leading to IllegalAccessExceptions [patch]

PicoContainer

greedy non-public constructors are prefered over public constructors leading to IllegalAccessExceptions [patch]

Created: 19/Aug/04 09:28 AM Updated: 20/Aug/04 05:49 AM

Component/s:

PicoContainer (Java)

Affects Version/s:

1.0

Fix Version/s:

1.1

Time Tracking:

Not Specified

File Attachments:

PICO-205.diff (5 kb)

Issue Links:

Duplicate

This issue duplicates:

~~PICO-201~~ PicoContainer finds the greediest constructor, even if it is protected or private

Description

« Hide

After introducing allowNonPublicClasses feature, a problem occurs whenever a class has a non-public satisfiable constructor accepting more parameters than the greediest public constructor and the CICA is running in normal (allowNonPublicClasses==false) mode. The non-public constructor is selected and IllegalAccessException occurs.

I've created a patch that ensures that only public constructors are considered as matching in allowNonPublicClasses==false mode.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Rafal Krzewski - 19/Aug/04 09:30 AM

a patch that fixes the problem.

[ Permlink | « Hide ]

Joerg Schaible - 19/Aug/04 10:02 AM

Already fixed.

[ Permlink | « Hide ]

Rafal Krzewski - 20/Aug/04 05:30 AM

Ah, I see it was fixed on the trunk. How about applying my patch on PICOCONTAINER_RELEASE_1_0_BRANCH and releasing pico 1.0.1?

[ Permlink | « Hide ]

Joerg Schaible - 20/Aug/04 05:49 AM

There's also a released pico-1.1-beta-1. Can you use it?
In any case I would apply the (compatible) changes from HEAD, since I run in a maintenace nightmare otherwise.