Perf4J

GoogleChartGeneratorTest fails unless timezone is GMT-5

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.9.12
  • Component/s: Perf4J base
  • Labels:
    None
  • Environment:
    Computer's timezone is set to British Summer Time
  • Number of attachments :
    1

Description

The expected results for {testThreeDataPoints}, {testTwoSeriesThreeDataPoints}, and {testGermanLocale} are all hardcoded to GMT-5 (EST). If invoked in any other environment the tests will fail.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jonathan Stafford added a comment -

Allows setting a system-wide setting for the timezone to use when generating the data timestamps.

Since a lot of companies seem to run their severs on GMT and workstations on local time, this might be generally useful beyond just allowing the test to pass.

Show
Jonathan Stafford added a comment - Allows setting a system-wide setting for the timezone to use when generating the data timestamps. Since a lot of companies seem to run their severs on GMT and workstations on local time, this might be generally useful beyond just allowing the test to pass.
Hide
Permalink
Jonathan Stafford added a comment -

FYI, the title should have been GMT-6. Which is fairly is fairly obvious if you look at the project team page.

Show
Jonathan Stafford added a comment - FYI, the title should have been GMT-6. Which is fairly is fairly obvious if you look at the project team page.
Hide
Permalink
Alex Devine added a comment -

Only change I made is to put the TimeZone on the GroupedTimingStatistics class, as this is where times originate as ms since they epoch and need to be converted to date/time strings.

Show
Alex Devine added a comment - Only change I made is to put the TimeZone on the GroupedTimingStatistics class, as this is where times originate as ms since they epoch and need to be converted to date/time strings.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.