Perf4J

Need to trim the TagNamesToExpose in JmxAttributeStatisticsAppender

Details

  • Number of attachments :
    0

Description

I found a small perf4j bug. It looks like you need to trim the TagNamesToExpose in JmxAttributeStatisticsAppender (I haven't opened the source to verify)
I have had to resort to some thing like this:

<!-- exposes perf4j to JMX -->
<appender name="Perf4jJMX" class="org.perf4j.log4j.JmxAttributeStatisticsAppender">
<param name="TagNamesToExpose"
value="TravelerEmailFeedHandler.pageEnd,ListingContactEmailFeedHandler.pageEnd,
,NotifierFeedHandler.pageEnd,AnalyzerFeedHandler.pageEnd,InquiryBuilderFeedHandler.pageEnd,
,HcDataAggregateFeedHandler.handleEntry,AnalyzerFeedHandler.processInquiries,
,InquiryBuilderFeedHandler.processInquiries,InquiryBuilder.store,InquiryBuilder.buildInquiry,
,SenderFeedHandler.processInquiries,SenderFeedHandler.send,EmailSender.send,
,TemplateRenderer.processTemplate,TemplateRenderer.getTemplate,DB.selectInquiryContactId1,
,DB.selectInquiryContactId2,DB.selectListingContact,DB.insertContact,DB.updateContact,
,DB.selectLocaleFields,DB.updateLocaleFields,DB.insertInquiryContactListings,DB.insertLocaleFields"/>
<param name="MBeanName" value="com.homeaway.beans:type=Perf4J,name=inquiryServicePerf"/>
</appender>

I get an "empty tag" in my JMX stats. BUT at least I can actually see the tag names in an orderly way in the config, so that I can properly verify my wiring.

Activity

Hide
Alex Devine added a comment -

Now we trim all the resultant elements wherever an option is meant to be multi-valued and delimited by a comma.

Show
Alex Devine added a comment - Now we trim all the resultant elements wherever an option is meant to be multi-valued and delimited by a comma.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: