Integration test failures

Maybe i am missing something but integration tests in trunk are also failing. By default they are not even running, I had to add surefire plugin configuration to the pom.

Failed tests:
testit0014(org.apache.maven.dotnet.integrationtests.MavenITmng0014ResolveLibraryDependency)
testit0008(org.apache.maven.dotnet.integrationtests.MavenITmng0008CSharpCompileWithProvidedDependency)
testit0004(org.apache.maven.dotnet.integrationtests.MavenITmng0004CSharpCompileWithDependency)
testit0007(org.apache.maven.dotnet.integrationtests.MavenITmng0007CSharpCompileTestLibrary)
testit0000(org.apache.maven.dotnet.integrationtests.MavenITmng0000CSharpCompileLibrary)
testit0004(org.apache.maven.dotnet.integrationtests.MavenITmng0004CSharpCompileWithDependency)
testit0005(org.apache.maven.dotnet.integrationtests.MavenITmng0005CSharpCompileWithTransitiveDependency)
testit0007(org.apache.maven.dotnet.integrationtests.MavenITmng0007CSharpCompileTestLibrary)
testit0008(org.apache.maven.dotnet.integrationtests.MavenITmng0008CSharpCompileWithProvidedDependency)
testit0009(org.apache.maven.dotnet.integrationtests.MavenITmng0009CSharpCompileWithProvidedGacDependency)
testit0005(org.apache.maven.dotnet.integrationtests.MavenITmng0005CSharpCompileWithTransitiveDependency)
testit0000(org.apache.maven.dotnet.integrationtests.MavenITmng0000CSharpCompileLibrary)
testit0000(org.apache.maven.dotnet.integrationtests.MavenITmng0000CSharpCompileLibrary)
testit0004(org.apache.maven.dotnet.integrationtests.MavenITmng0004CSharpCompileWithDependency)
testit0005(org.apache.maven.dotnet.integrationtests.MavenITmng0005CSharpCompileWithTransitiveDependency)
testit0007(org.apache.maven.dotnet.integrationtests.MavenITmng0007CSharpCompileTestLibrary)
testit0008(org.apache.maven.dotnet.integrationtests.MavenITmng0008CSharpCompileWithProvidedDependency)

Tests run: 55, Failures: 17, Errors: 0, Skipped: 0

Patch to enable the integration tests

For instance for IT0000 which is a very simple build of .net I get this log.

[ERROR] Missing toolchain factory for type:dotnet. Possibly caused by misconfigured project.

Looking at the code it means that the plugin can't find an implementation of the toolchain for the dotnet role, but maven-dotnet-toolchain 0.16-incubating-SNAPSHOT is in the extensions of the pom and its components.xml looks right to me.

The test compiler plugin needs to be fixed first

Patch that fixes all it tests in trunk

• allows running its against either microsoft or mono (in the future should test against both)
• sets a parent pom for all tests that setups the toolchain

Also need:

copy http://svn.apache.org/repos/asf/incubator/nmaven/branches/NMAVEN_0.14/thirdparty/NUnit into trunk/thirdparty/NUnit
copy maven-dotnet-toolchain-0.16-incubating-SNAPSHOT.jar into M2_HOME/lib

the 2nd requirement is due to a problem with the plexus container not finding the DotNet toolchain will look into it afterwards now that I know IT tests pass

The toolchain config looks like

<toolchain>
        <type>dotnet</type>
        <provides>
            <frameworkVersion>2.0</frameworkVersion>
            <vendorVersion>2.0.50727</vendorVersion>
            <vendor>MICROSOFT</vendor>
            <id>.NET Framework 2.0</id>
        </provides>
        <configuration>
            <csharpCompiler>C:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\csc.exe</csharpCompiler>
            <nunitConsole>C:\Program Files\NUnit 2.4.8\bin\nunit-console.exe</nunitConsole> 
        </configuration>
    </toolchain>

Updated patch that makes easier to use its agains trunk or 0.14 branch (see convert-to-0.14.txt)

Tests related to the nunit testing fail (0007 is the basic one), see NMAVEN-8

Requires all linked issues to be fixed first and install the nunit assembly

last patch still needs the workaround of copying maven-dotnet-toolchain-0.16-incubating-SNAPSHOT.jar into M2_HOME/lib

The tests can be run with
mvn clean install -Dnmaven.vendor=MICROSOFT

Let's see if I can sum it up

For trunk:

• Apply core-integration-tests-trunk.patch
• copy maven-dotnet-toolchain-0.16-incubating-SNAPSHOT.jar to M2_HOME/lib
• Install NUnit in the local repo, doesn't seem to find the one installed in the gac by the 0.14 bootstrap
• I used the one from 0.14 branch, although doesn't matter much, tests don't pass
  copy http://svn.apache.org/repos/asf/incubator/nmaven/branches/NMAVEN_0.14/thirdparty/NUnit/NUnit.Framework.dll to
  C:\Documents and Settings\username\.m2\repository\NUnit\NUnit.Framework\2.2.8.0\NUnit.Framework-2.2.8.0.dll
• run mvn clean install -Dnmaven.vendor=MICROSOFT. Tests 0007 and 0019 doesn't pass, see NMAVEN-8

For 0.14:

• run the bootstrap as usual (I think only the NUnit installation is needed)
• unpack core-integration-tests-0.14.tgz which is a branch from trunk tests adapted to 0.14
• run mvn clean install. All tests pass

I've created a branch and partially applied this, adding a notes file for the changes I'm pursuing... let me know your thoughts.