jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Maven 2.x Webstart Plugin
  • MWEBSTART-88

HttpJarSignClient - New goal "httpsign" which will sign jar files by submitting them to a signing service via HTTP Post

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Testcase included:
    yes

Description

The patch and new files attached to this issue are newer and make the contributions in MJAR-35 obsolete.

There is a test pom.xml that you can do a "mvn install" on to see the new goal working.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. File
    jarplugin.diff
    13/Apr/06 8:54 AM
    1 kB
    David Boden
  2. Hide
    Zip Archive
    jar-plugin-newfiles.zip
    13/Apr/06 8:54 AM
    44 kB
    David Boden
    1. Java Source File
      src/main/.../jar/HttpJarSignerClient.java 3 kB
    2. Java Source File
      src/.../HttpJarSignerClientException.java 0.3 kB
    3. Java Source File
      src/main/java/.../jar/HttpJarSignerMojo.java 2 kB
    4. Java Source File
      src/main/java/.../jar/JarSignerMojo.java 2 kB
    5. XML File
      src/test/resources/httpsign-0/pom.xml 0.9 kB
    Download Zip
    Show
    Zip Archive
    jar-plugin-newfiles.zip
    13/Apr/06 8:54 AM
    44 kB
    David Boden

Issue Links

depends upon

New Feature - A new feature of the product, which has yet to be developed. MJAR-35 Abstraction for JarSignMojo so that webstart plugin can allow the user to choose how their jars are signed

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Jerome Lacoste added a comment - 13/Apr/06 9:59 AM

In case we don't want the official maven-jar-plugin to depend on httpclient, another solution is to:

1- check MJAR-35 as is
2- move this mojo to a plugin to the mojo plugin

Show
Jerome Lacoste added a comment - 13/Apr/06 9:59 AM In case we don't want the official maven-jar-plugin to depend on httpclient, another solution is to: 1- check MJAR-35 as is 2- move this mojo to a plugin to the mojo plugin
Hide
Permalink
Arik Kfir added a comment - 13/Apr/06 10:28 AM

Just an idea - this can be a cool Plexus component (JAR signing, that is...especially by HTTP)

Show
Arik Kfir added a comment - 13/Apr/06 10:28 AM Just an idea - this can be a cool Plexus component (JAR signing, that is...especially by HTTP)
Hide
Permalink
John Casey added a comment - 17/Apr/06 10:48 AM

I don't like the idea of making the maven-jar-plugin dependent on httpclient. Also, I'm not wild about creating an interface to allow grouping the JarSignMojo with some other class that won't be used from the jar plugin itself. Anything making use of such an abstraction should probably declare an adapter...

As for putting jar-signing into plexus, and making these two alternative implementations, I think that sounds nice for the longer term, but I'm not sure it's a good idea to disrupt the current release cycle of the jar plugin for that (since we'd have to implement/test such a new provider framework within plexus, then call a vote to release it ahead of the jar plugin's release).

David, if we did turn this into a plexus component set, would you be okay with us using your submitted HTTP-based signer in the plexus project, rather than directly within the maven project? It uses an MIT license.

What do others think about this as a solution? For the short term, I'd like to see the webstart plugin create a small adapter for the JarSignMojo, and implement a framework around it to allow the use of the HTTP-based alternative instead. From there, we can improve this framework, and eventually make a plexus component set out of it. Whether that component set lives in the maven/shared SVN space (my first vote) or the plexus project (not sure about concerns of code crossing in/out of the maven project here), we can eventually evolve it into a reusable project in its own right. However, I think such a project needs to evolve from the webstart plugin, not from the jar plugin.

Show
John Casey added a comment - 17/Apr/06 10:48 AM I don't like the idea of making the maven-jar-plugin dependent on httpclient. Also, I'm not wild about creating an interface to allow grouping the JarSignMojo with some other class that won't be used from the jar plugin itself. Anything making use of such an abstraction should probably declare an adapter... As for putting jar-signing into plexus, and making these two alternative implementations, I think that sounds nice for the longer term, but I'm not sure it's a good idea to disrupt the current release cycle of the jar plugin for that (since we'd have to implement/test such a new provider framework within plexus, then call a vote to release it ahead of the jar plugin's release). David, if we did turn this into a plexus component set, would you be okay with us using your submitted HTTP-based signer in the plexus project, rather than directly within the maven project? It uses an MIT license. What do others think about this as a solution? For the short term, I'd like to see the webstart plugin create a small adapter for the JarSignMojo, and implement a framework around it to allow the use of the HTTP-based alternative instead. From there, we can improve this framework, and eventually make a plexus component set out of it. Whether that component set lives in the maven/shared SVN space (my first vote) or the plexus project (not sure about concerns of code crossing in/out of the maven project here), we can eventually evolve it into a reusable project in its own right. However, I think such a project needs to evolve from the webstart plugin, not from the jar plugin.
Hide
Permalink
John Casey added a comment - 17/Apr/06 11:21 AM

fwiw, I think this issue needs to be reassigned to the webstart plugin in the MOJO project. I'll leave it here for now, for comments.

Show
John Casey added a comment - 17/Apr/06 11:21 AM fwiw, I think this issue needs to be reassigned to the webstart plugin in the MOJO project. I'll leave it here for now, for comments.
Hide
Permalink
Jerome Lacoste added a comment - 22/Jun/06 6:11 PM

This issue is related to MOJO-393. It should be moved to webstart plugin. Please do so if you want (we need to create a webstart project in Jira first).

Show
Jerome Lacoste added a comment - 22/Jun/06 6:11 PM This issue is related to MOJO-393. It should be moved to webstart plugin. Please do so if you want (we need to create a webstart project in Jira first).

People

  • Assignee:
    Unassigned
    Reporter:
    David Boden
Vote (0)
Watch (0)

Dates

  • Created:
    13/Apr/06 8:54 AM
    Updated:
    01/Jan/08 5:02 PM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.