Maven 2.x Webstart Plugin

Allow keystore to be: a file, classpath resource or remote resource (not only a file)

Details

  • Type: Improvement Improvement
  • Status: In Progress In Progress
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: 1.0-beta-4
  • Component/s: jnlp-download-servlet, jnlps
  • Labels:
    None
  • Number of attachments :
    2

Description

Now "keystore" parameter must point to a file.
It could be a resource instead:

There is a little to do. Copy solution from maven-checkstyle-plugin ver.2.1:

src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReport.java class - "configLocation" property, "getConfigFile() method and src/main/java/org/apache/maven/plugin/checkstyle/Locator.java class

In maven-checkstyle-plugin "plugins/trunk" this code is changed.

You can look at maven-clover-plugin and its "licenseLocation" property.

  1. Text File
    mwebstart-39-pom.xml.patch
    06/Aug/12 9:38 AM
    0.6 kB
    Andreas Kuhtz
  2. Text File
    SignToolTest.java.patch
    06/Aug/12 6:30 AM
    0.6 kB
    Andreas Kuhtz

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MCHECKSTYLE-42 checkstyle does not take into account proxy settings from settings.xml

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jerome Lacoste added a comment -

hei Grzegorz, would you mind producing a patch ? It looks like you've got it all covered !

Show
Jerome Lacoste added a comment - hei Grzegorz, would you mind producing a patch ? It looks like you've got it all covered !
Hide
Permalink
Jerome Lacoste added a comment -

Note that using an URL can cause other issues, like proxy management, as identified by MCHECKSTYLE-42.

So until someone comes with a need to support this, and actually provides a patch or help to provide / test one, I will let this rest

Show
Jerome Lacoste added a comment - Note that using an URL can cause other issues, like proxy management, as identified by MCHECKSTYLE-42 . So until someone comes with a need to support this, and actually provides a patch or help to provide / test one, I will let this rest
Hide
Permalink
Tony Chemit added a comment - - edited

We could implements the new feature. If there is some issues with http proxies, we could treat this problem in another time ?

Done see rev 17071

Show
Tony Chemit added a comment - - edited We could implements the new feature. If there is some issues with http proxies, we could treat this problem in another time ? Done see rev 17071
Hide
Permalink
Andreas Kuhtz added a comment -

Hi Tony,
The test SignToolTest:testGetKeyStoreFile() with the 

"file://"

prefix fails on windows. Not sure if using 

"file:///"

works on unix as well ... See attached patch.

Show
Andreas Kuhtz added a comment - Hi Tony, The test SignToolTest:testGetKeyStoreFile() with the "file: //" prefix fails on windows. Not sure if using "file: ///" works on unix as well ... See attached patch.
Hide
Permalink
Tony Chemit added a comment -

Patch Applied see rev 17264

thanks

Show
Tony Chemit added a comment - Patch Applied see rev 17264 thanks
Hide
Permalink
Andreas Kuhtz added a comment -

The it MWEBSTART-39 fails too on windows. See patch mwebstart-39-pom.xml.patch attached.

Show
Andreas Kuhtz added a comment - The it MWEBSTART-39 fails too on windows. See patch mwebstart-39-pom.xml.patch attached.
Hide
Permalink
Tony Chemit added a comment -

Arch we are doomed

Patch 2 applied see rev 17265

Need to add a windows build on bamboo for this project to avoid this!

Show
Tony Chemit added a comment - Arch we are doomed Patch 2 applied see rev 17265 Need to add a windows build on bamboo for this project to avoid this!

People

  • Assignee:
    Tony Chemit
    Reporter:
    Grzegorz Slowikowski
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: