Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 1.0-alpha-2
-
Component/s: None
-
Labels:None
-
Number of attachments :
Description
I want this before 1.0. Extract from email sent to mojo user list:
> what should be the default directory for JNLP resources?
src/main/jnlp is the official.
> (The default location for the JNLP template is
> src/jnlp/template.vm and not src/main/jnlp/template.vm)
We place the template in a different location. The reason being that the resources are copied over, while the template is not. The plugin would have to do some sort of special excluding if the template was located in the same location as the resources.
Maybe should we change this to
src/main/jnlp/template.vm
and
src/main/jnlp/resources or src/main/resources
I am not sure of using src/main/resources as this directory may already be used to contain jar specific resources.
Any maven experts who could give some feedback?
Issue Links
| This issue depends upon: | ||||
| MWEBSTART-15 | WebStart Plugin - Changeable JNLP resources directory |
|
|
|
I'm not a maven expert, but here is my feedback:
I would expect all JNLP plugin specific files and resources beneath one base directory.
The question then is:
src/jnlp
or
src/main/jnlp
According to the documentation I found, the src/main directory should contain the source material
for the main build artifact.
Building some kind of distribution is closely related to the main artifact as you can see with the
assembly plugin. The default location for assembly descriptors is src/main/assembly.
If you agree, that webstart packaging is another kind of distribution for the main artifact, then I would
opt for src/main/jnlp.
Moreover, currently it's recommended to create a separate module to package the artifact of another module
as webstart app. In this case, the module's main artifact is the result produced by the webstart plugin.
So my preference is:
src/main/jnlp/template.vm for the JNLP template
src/main/jnlp/resources/ as dir for additional resources to copy to the work directory
(I think src/main/resources is reserved for resources, that should be included in the artifact jar.)
Ideally, the JNLP resources and the JNLP template can optionally get filtered like "normal" resources
from src/main/resources.
That's just my point of view, other opinions are welcome ...