Mojo's Webstart Maven Plugin
  1. Mojo's Webstart Maven Plugin
  2. MWEBSTART-149

Add parameter maxMemory to the org.codehaus.mojo.webstart.JarSignMojoConfig fields

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0-alpha-2
    • Fix Version/s: 1.0-beta-3
    • Component/s: sign
    • Labels:
      None
    • Number of attachments :
      1

      Description

      When the size of the jar to sign is to big, we get a java.lang.OutOfMemoryError: Java heap space

      So it would be great to add the maxMemory to be able to set the Xmx.

        Issue Links

          Activity

          Hide
          Tony Chemit added a comment -

          I made a version of the webstart plugin based on maven-jarsigner-plugin to allow maxMemory property.

          Let me know if you want me to post the code

          Yes I am very interesting of this

          Show
          Tony Chemit added a comment - I made a version of the webstart plugin based on maven-jarsigner-plugin to allow maxMemory property. Let me know if you want me to post the code Yes I am very interesting of this
          Hide
          Mathieu Filotto added a comment -

          Yes it is sad, so my patch is not very clean : I had to set the fields through introspection.
          Let me clean up my code, and I will post it on that issue
          (I worked from the patch given by Jerome Lacoste, thanks for your work)

          Show
          Mathieu Filotto added a comment - Yes it is sad, so my patch is not very clean : I had to set the fields through introspection. Let me clean up my code, and I will post it on that issue (I worked from the patch given by Jerome Lacoste, thanks for your work)
          Hide
          Tony Chemit added a comment -

          Yes Mathieu, that's extactly what I call a very "closed code" (being force to use introspection to set fields in a class).

          Don't you think it would be easier to improve the jarsigner mojo with simple setters?

          Anyway there is still another problem even with the setters added, the workdir of the jarsigner is hardcoded with this

           commandLine.setWorkingDirectory( this.project.getBasedir() ); 

          It reminds me that i should also put setters everywhere in webstart mojo...

          Show
          Tony Chemit added a comment - Yes Mathieu, that's extactly what I call a very "closed code" (being force to use introspection to set fields in a class). Don't you think it would be easier to improve the jarsigner mojo with simple setters? Anyway there is still another problem even with the setters added, the workdir of the jarsigner is hardcoded with this commandLine.setWorkingDirectory( this .project.getBasedir() ); It reminds me that i should also put setters everywhere in webstart mojo...
          Hide
          Mathieu Filotto added a comment -

          You're right, adding these setters to maven-jarsigner-plugin would be much better.

          I solved the working directory issue by setting the maven project the same dirty way.

          Show
          Mathieu Filotto added a comment - You're right, adding these setters to maven-jarsigner-plugin would be much better. I solved the working directory issue by setting the maven project the same dirty way.
          Hide
          Tony Chemit added a comment -

          Done in r14942.

          Show
          Tony Chemit added a comment - Done in r14942.

            People

            • Assignee:
              Tony Chemit
              Reporter:
              Mathieu Filotto
            • Votes:
              1 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: