Add parameter maxMemory to the org.codehaus.mojo.webstart.JarSignMojoConfig fields

To do so, I think it is probably necessary to migrate to maven-jarsigner-plugin

Here's a work in progress to reuse the maven-jarsigner-plugin

Unfortunately the jar:sign mojo which I wrote earlier is incompatible codewise with the version that was moved to the new jarsigner plugin.

So there's a bit of work to do on the jarsigner to properly expose the code. I've started doing it but I don't have the time today to look into it completely. Someone might want to finish making the jarsigner plugin compatible with the old interface required by the webstart plugin.

I will send some issues to the maven-jarsigner-plugin to make this possible.

I can not understand why the jarsigner plugin is closed ?

I can not understand why the jarsigner plugin is closed ?

WDYM?
maven-jarsigner-plugin is not closed, maven-jar-plugin:sign is.

I made a version of the webstart plugin based on maven-jarsigner-plugin to allow maxMemory property.
Let me know if you want me to post the code

I just mean that the java code is not open at all.

As the mojo have private field and no setter it is impossible to reuse the code of this plugin. This is sad but I will open some issues on the plugin to change this.

I developp a bit more my sadness : while reusing the mojo inside anoter mojo we can not use the parameter injection via javadoc annotation so the code is not reusable at all.

Correct me if I am wrong?

I made a version of the webstart plugin based on maven-jarsigner-plugin to allow maxMemory property.

Let me know if you want me to post the code

Yes I am very interesting of this

Yes it is sad, so my patch is not very clean : I had to set the fields through introspection.
Let me clean up my code, and I will post it on that issue
(I worked from the patch given by Jerome Lacoste, thanks for your work)

Yes Mathieu, that's extactly what I call a very "closed code" (being force to use introspection to set fields in a class).

Don't you think it would be easier to improve the jarsigner mojo with simple setters?

Anyway there is still another problem even with the setters added, the workdir of the jarsigner is hardcoded with this

 commandLine.setWorkingDirectory( this.project.getBasedir() ); 

It reminds me that i should also put setters everywhere in webstart mojo...

You're right, adding these setters to maven-jarsigner-plugin would be much better.

I solved the working directory issue by setting the maven project the same dirty way.

Done in r14942.