Mojo Web Minifier Maven Plugin

Splitting and renaming of the parts does not work as described

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0.1
  • Fix Version/s: 1.0.1
  • Labels:
    None
  • Number of attachments :
    4

Description

Splitting and naming of the parts does not appear to work as described.
Have a look at the attached files. Defining the split point to be d.js produces 1.js with a.js,b.js, and c.js included and a separate file including d.js. As per description of the webminifier's behaviour this should result in one file with the configured name including all the js files.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Christopher Hunt added a comment -

Can you please try this with the latest snapshot if you're not already doing so and, if the problem persists, can you please provide a complete project whereby I can reproduce the problem.

Thanks!

Show
Christopher Hunt added a comment - Can you please try this with the latest snapshot if you're not already doing so and, if the problem persists, can you please provide a complete project whereby I can reproduce the problem. Thanks!
Hide
Permalink
Hubert Przybysz added a comment - - edited

Hi,
Attached a simple test-webminifier project to recreate the problem, as requested. The output files are in target/webminifier-output after the build.
Regards / Hubert.

Show
Hubert Przybysz added a comment - - edited Hi, Attached a simple test-webminifier project to recreate the problem, as requested. The output files are in target/webminifier-output after the build. Regards / Hubert.
Hide
Permalink
Christopher Hunt added a comment -

I've just remembered that this is the required behaviour!

If you have a, b, c, d where a depends on b, b on c, c on d, then if you define a as a split point, a should be in its own file with b, c and d in one other file.

The reason things are this way is so that, if a is a library (for example) then you can ship the library with no dependencies.

I'm going to revert the fix made here as it has broken other projects.

Show
Christopher Hunt added a comment - I've just remembered that this is the required behaviour! If you have a, b, c, d where a depends on b, b on c, c on d, then if you define a as a split point, a should be in its own file with b, c and d in one other file. The reason things are this way is so that, if a is a library (for example) then you can ship the library with no dependencies. I'm going to revert the fix made here as it has broken other projects.
Hide
Permalink
Christopher Hunt added a comment -

Reverted change.

Show
Christopher Hunt added a comment - Reverted change.

People

  • Assignee:
    Christopher Hunt
    Reporter:
    Hubert Przybysz
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: