Details

    • Type: New Feature New Feature
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Patch Submitted:
      Yes
    • Number of attachments :
      0

      Description

      I rewrote most of the code.

      Now it will minify the css files also and use the existing tags from the html, instead of creating new ones, preserving the script declarations in the head and body. It minimized the html file also, removing comments and spaces. Split points are now created according to the tag's ID attribute.

      The closure javascript minifier searches for function names in strings that shouldn't be replaced (needed the rhino parser for that, which had a hexadecimal parsing bug, that's why I have included it in the code) and adds other externs also for the advanced compilation.

      The CSS minifier changes the relative paths when merged (since relative paths a relative to the file itself, which changes, once merged) and warns for nonexistent paths etc.

      And other minor and major changes.

      The code still needs some generalization and changes:
      Javascript property renaming should be enableable in the advanced phase
      YUI CSS minifier should also be added as an option
      the yui and closure options should be separated and if the same css and javascript files are included in different HTML files, they should be resolved, not compressed in a different file
      the compression shouldn't run if the parent directory's modified date didn't change.
      tests

        Activity

        Hide
        Christopher Hunt added a comment -

        I think it is really great that you'd like to contribute, but what I'm seeing is a complete re-write with no tests and no rationale for why it has been re-written.

        If you'd like to contribute then that's great, but I find it hard to understand the need for a re-write at this stage.

        Thanks once again.

        Show
        Christopher Hunt added a comment - I think it is really great that you'd like to contribute, but what I'm seeing is a complete re-write with no tests and no rationale for why it has been re-written. If you'd like to contribute then that's great, but I find it hard to understand the need for a re-write at this stage. Thanks once again.
        Hide
        Pap Lőrinc added a comment -

        Please read the description I wrote for this issue, I highlight some of the features and motivations behind the rewrite.
        The rest is in the code that I still encourage you to read. Please stop taking it as an insult against your code, it's unprofessional. I learned many things from your code, but it needed changes.

        Show
        Pap Lőrinc added a comment - Please read the description I wrote for this issue, I highlight some of the features and motivations behind the rewrite. The rest is in the code that I still encourage you to read. Please stop taking it as an insult against your code, it's unprofessional. I learned many things from your code, but it needed changes.
        Hide
        Christopher Hunt added a comment -

        I have read your initial description, looked at your code, but I'm still bewildered as to why you thought everything had to be re-written.

        If you'd like to incorporate the functionality you desire, leveraging the existing code base, and supplying tests then you'll be very welcome. Please raise individually JIRAs for the features that you would like to see, or any bugs that you wish to report.

        Thanks once again.

        Show
        Christopher Hunt added a comment - I have read your initial description, looked at your code, but I'm still bewildered as to why you thought everything had to be re-written. If you'd like to incorporate the functionality you desire, leveraging the existing code base, and supplying tests then you'll be very welcome. Please raise individually JIRAs for the features that you would like to see, or any bugs that you wish to report. Thanks once again.
        Hide
        Pap Lőrinc added a comment -

        Why would I do that?
        I already made a version that is working for me.

        Show
        Pap Lőrinc added a comment - Why would I do that? I already made a version that is working for me.
        Hide
        Christopher Hunt added a comment -

        I've discussed this submission with some colleagues and we have decided to not proceed with it for the reasons previously stated. Thanks again for your support and enthusiam.

        Show
        Christopher Hunt added a comment - I've discussed this submission with some colleagues and we have decided to not proceed with it for the reasons previously stated. Thanks again for your support and enthusiam.

          People

          • Assignee:
            Christopher Hunt
            Reporter:
            Pap Lőrinc
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: