Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.4-SNAPSHOT
    • Labels:
      None
    • Environment:
      Solaris 10, Weblogic 10.3.1, weblogic-maven-plugin 2.9.2-SNAPSHOT
    • Patch Submitted:
      Yes
    • Number of attachments :
      1

      Description

      With WebLogic 10.3 new features are available (e.g. appc has a new option "-clientJarOutputDir <dir>") and some API changed slightly (as already reported in #MOJO-1396).

      The attached patch adds support for the aforementioned appc option. Instead creating a new mojo (the road with #MOJO-1396 did) this patch tackles the API changes by calling the changed setters via reflection. The NPE fix mentioned in #MOJO-1396 is also included.

        Issue Links

          Activity

          Hide
          David J. M. Karlsen added a comment -

          Hmm, I think it would be better to save the systemproperty value "java.protocol.handler.pkgs" in a varible - and set this again (if it's not null).
          I'm wondering of moving this up to the AbstractWeblogicMojo so that it's done in all cases - or is that not needed?

          Show
          David J. M. Karlsen added a comment - Hmm, I think it would be better to save the systemproperty value "java.protocol.handler.pkgs" in a varible - and set this again (if it's not null). I'm wondering of moving this up to the AbstractWeblogicMojo so that it's done in all cases - or is that not needed?
          Hide
          Jon Osborn added a comment - - edited

          I agree. Should probably move it to the abstract class. Should probably up the version for this change because there are more changes required. The dependencies in the pom, for example, also have to drastically change.

          Show
          Jon Osborn added a comment - - edited I agree. Should probably move it to the abstract class. Should probably up the version for this change because there are more changes required. The dependencies in the pom, for example, also have to drastically change.
          Hide
          Jon Osborn added a comment -

          And just for clarity, we create a new mojo for clientgen9 because the difference between 8 and 9 were really substantial. I suppose the change could have used reflection to discover which one to use but we felt that the user would be picking the weblogic instance anyway.

          Show
          Jon Osborn added a comment - And just for clarity, we create a new mojo for clientgen9 because the difference between 8 and 9 were really substantial. I suppose the change could have used reflection to discover which one to use but we felt that the user would be picking the weblogic instance anyway.
          Hide
          Jon Osborn added a comment -

          I applied the patch to trunk and updated the pom version to 2.9.3-SNAPSHOT.

          Show
          Jon Osborn added a comment - I applied the patch to trunk and updated the pom version to 2.9.3-SNAPSHOT.
          Hide
          Jon Osborn added a comment -

          I uploaded 2.9.3-SNAPSHOT so please try that out. The source was updated with the patch and I tweaked the pom.xml for 2.9.3-SNAPSHOT.

          Show
          Jon Osborn added a comment - I uploaded 2.9.3-SNAPSHOT so please try that out. The source was updated with the patch and I tweaked the pom.xml for 2.9.3-SNAPSHOT.
          Hide
          Jon Osborn added a comment -

          Any testing on this?

          Show
          Jon Osborn added a comment - Any testing on this?

            People

            • Assignee:
              David J. M. Karlsen
              Reporter:
              Torsten Juergeleit
            • Votes:
              3 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: