Add Maven version used to Created-By entry in manifest

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1.1
  • Fix Version/s: 2.2
  • Component/s: None
  • Labels:
    None
  • Environment:
    n/a

Description

Upgrade the dependency to org.apache.maven:maven-archiver to newer version (when released) to get the version of Maven Core used for building included in the Created-By manifest entry. The call to MavenArchiver also needs to be slightly updated to pass along the MavenSession.

Issue Links

depends upon

Bug - A problem which impairs or prevents the functions of the product. MSHARED-38 Archiver should be adding "Created-By: Apache Maven _2.0.4_" to the manifest

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Improvement - An improvement or enhancement to an existing feature or task. MJAR-148 Add Maven version used to Created-By entry in manifest

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anders Hammar added a comment - - edited

Attached patch, including IT. Obviously, the maven-archiver version needs to be updated to a release version once available.

Show
Anders Hammar added a comment - - edited Attached patch, including IT. Obviously, the maven-archiver version needs to be updated to a release version once available.
Hide
Permalink
Dennis Lundberg added a comment -

Hi Anders,

Do I understand correctly that this will only work for Maven 3.0.4+ ?

Show
Dennis Lundberg added a comment - Hi Anders, Do I understand correctly that this will only work for Maven 3.0.4+ ?
Hide
Permalink
Dennis Lundberg added a comment -

Patch applied in r1235053 with minor modifications.

Show
Dennis Lundberg added a comment - Patch applied in r1235053 with minor modifications.
Hide
Permalink
Anders Hammar added a comment -

@Dennis: Yes, the Maven version is only included in the Manifest when building with 3.0.4+. Older version will only state "Apache Maven" (the same as currently).

Show
Anders Hammar added a comment - @Dennis: Yes, the Maven version is only included in the Manifest when building with 3.0.4+. Older version will only state "Apache Maven" (the same as currently).

People

  • Assignee:
    Dennis Lundberg
    Reporter:
    Anders Hammar
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: