Maven 2.x WAR Plugin

Final manifest not written to exploded location

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.1-alpha-1
  • Fix Version/s: backlog
  • Component/s: manifest
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

When I open up my generated WAR file, the Manifest file contains all the entries I specified. This is correct. However, when I look into the exploded location, it's just the file I had in my project to begin with.

The exploded Manifest should be updated with the final contents.

  1. File
    mvn167-with-it.diff
    18/Aug/09 6:49 PM
    8 kB
    Haikal Saadh
  2. File
    patch.diff
    17/Aug/09 11:09 PM
    3 kB
    Haikal Saadh

Issue Links

supercedes

New Feature - A new feature of the product, which has yet to be developed. MWAR-233 Please allow for MANIFEST.MF in exploded

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Haikal Saadh added a comment - - edited

This is important so that, say, Spring Tools Suite for eclipse can deploy a war project to DM Server.

Funny thing is, with 2.1-beta-1, if you do either a war:war, or a war:exploded, the custom manifest (generated by maven-bundle-plugin) is ignored, BUT if I do a maven package, the output directory contains the correct manifest.

Show
Haikal Saadh added a comment - - edited This is important so that, say, Spring Tools Suite for eclipse can deploy a war project to DM Server. Funny thing is, with 2.1-beta-1, if you do either a war:war, or a war:exploded, the custom manifest (generated by maven-bundle-plugin) is ignored, BUT if I do a maven package, the output directory contains the correct manifest.
Hide
Permalink
Haikal Saadh added a comment - - edited

Here's a patch that copies a user specified manifest to the correct place when you do war:exploded.

First time working on a maven plugin, so go easy

patch is against /tags/maven-war-plugin-2.1-beta-1

Show
Haikal Saadh added a comment - - edited Here's a patch that copies a user specified manifest to the correct place when you do war:exploded. First time working on a maven plugin, so go easy patch is against /tags/maven-war-plugin-2.1-beta-1
Haikal Saadh made changes -
Field Original Value New Value
Attachment patch.diff [ 43855 ]
Hide
Permalink
Haikal Saadh added a comment -

Same as above, but now with an added integration test.

Show
Haikal Saadh added a comment - Same as above, but now with an added integration test.
Haikal Saadh made changes -
Attachment mvn167-with-it.diff [ 43869 ]
Hide
Permalink
Marcin Zajaczkowski added a comment -

Any chance to review and apply attached patches?

It's important for example when you use manifest.mf to keep information about build number or date which is displayed in the application UI.

Show
Marcin Zajaczkowski added a comment - Any chance to review and apply attached patches? It's important for example when you use manifest.mf to keep information about build number or date which is displayed in the application UI.
Dennis Lundberg made changes -
Patch Submitted [Yes]
Hide
Permalink
Dennis Lundberg added a comment -

@Paul
Is this releated to MWAR-197.

@Haikal
If you are using another plugin to generate a custom manifest that you include in the WAR Plugin's configuration, then you need to execute that plugin before the war or exploded goal. Something like this:
mvn manifest:create-custom war:war

Show
Dennis Lundberg added a comment - @Paul Is this releated to MWAR-197 . @Haikal If you are using another plugin to generate a custom manifest that you include in the WAR Plugin's configuration, then you need to execute that plugin before the war or exploded goal. Something like this: mvn manifest:create-custom war:war
Hide
Permalink
Paul Benedict added a comment -

Dennis, no, it is not related. MWAR-197 deals with missing manifest entries. This ticket deals with the entire manifest being absent from target/<WAR_EXPLODED_LOCATION>.

Show
Paul Benedict added a comment - Dennis, no, it is not related. MWAR-197 deals with missing manifest entries. This ticket deals with the entire manifest being absent from target/<WAR_EXPLODED_LOCATION>.
Hide
Permalink
Dennis Lundberg added a comment -

Paul, could you attach a small sample project with your configuration?

Show
Dennis Lundberg added a comment - Paul, could you attach a small sample project with your configuration?
Stéphane Nicoll made changes -
Link This issue supercedes MWAR-233 [ MWAR-233 ]
Stéphane Nicoll made changes -
Fix Version/s 2.2 [ 15001 ]
Priority Minor [ 4 ] Major [ 3 ]
Dennis Lundberg made changes -
Component/s manifest [ 14515 ]
Dennis Lundberg made changes -
Fix Version/s 2.3 [ 18298 ]
Fix Version/s 2.2 [ 15001 ]
Dennis Lundberg made changes -
Fix Version/s 2.4 [ 18834 ]
Fix Version/s 2.3 [ 18298 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Paul Benedict
Vote (10)
Watch (6)

Dates

  • Created:
    Updated: