Maven WAR Plugin
  1. Maven WAR Plugin
  2. MWAR-167

Final manifest not written to exploded location

    Details

    • Type: Bug Bug
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.1-alpha-1
    • Fix Version/s: backlog
    • Component/s: manifest
    • Labels:
      None
    • Patch Submitted:
      Yes
    • Number of attachments :
      2

      Description

      When I open up my generated WAR file, the Manifest file contains all the entries I specified. This is correct. However, when I look into the exploded location, it's just the file I had in my project to begin with.

      The exploded Manifest should be updated with the final contents.

      1. mvn167-with-it.diff
        8 kB
        Haikal Saadh
      2. patch.diff
        3 kB
        Haikal Saadh

        Issue Links

          Activity

          Hide
          Haikal Saadh added a comment - - edited

          This is important so that, say, Spring Tools Suite for eclipse can deploy a war project to DM Server.

          Funny thing is, with 2.1-beta-1, if you do either a war:war, or a war:exploded, the custom manifest (generated by maven-bundle-plugin) is ignored, BUT if I do a maven package, the output directory contains the correct manifest.

          Show
          Haikal Saadh added a comment - - edited This is important so that, say, Spring Tools Suite for eclipse can deploy a war project to DM Server. Funny thing is, with 2.1-beta-1, if you do either a war:war, or a war:exploded, the custom manifest (generated by maven-bundle-plugin) is ignored, BUT if I do a maven package, the output directory contains the correct manifest.
          Hide
          Haikal Saadh added a comment - - edited

          Here's a patch that copies a user specified manifest to the correct place when you do war:exploded.

          First time working on a maven plugin, so go easy

          patch is against /tags/maven-war-plugin-2.1-beta-1

          Show
          Haikal Saadh added a comment - - edited Here's a patch that copies a user specified manifest to the correct place when you do war:exploded. First time working on a maven plugin, so go easy patch is against /tags/maven-war-plugin-2.1-beta-1
          Hide
          Haikal Saadh added a comment -

          Same as above, but now with an added integration test.

          Show
          Haikal Saadh added a comment - Same as above, but now with an added integration test.
          Hide
          Marcin Zajaczkowski added a comment -

          Any chance to review and apply attached patches?

          It's important for example when you use manifest.mf to keep information about build number or date which is displayed in the application UI.

          Show
          Marcin Zajaczkowski added a comment - Any chance to review and apply attached patches? It's important for example when you use manifest.mf to keep information about build number or date which is displayed in the application UI.
          Hide
          Dennis Lundberg added a comment -

          @Paul
          Is this releated to MWAR-197.

          @Haikal
          If you are using another plugin to generate a custom manifest that you include in the WAR Plugin's configuration, then you need to execute that plugin before the war or exploded goal. Something like this:
          mvn manifest:create-custom war:war

          Show
          Dennis Lundberg added a comment - @Paul Is this releated to MWAR-197 . @Haikal If you are using another plugin to generate a custom manifest that you include in the WAR Plugin's configuration, then you need to execute that plugin before the war or exploded goal. Something like this: mvn manifest:create-custom war:war
          Hide
          Paul Benedict added a comment -

          Dennis, no, it is not related. MWAR-197 deals with missing manifest entries. This ticket deals with the entire manifest being absent from target/<WAR_EXPLODED_LOCATION>.

          Show
          Paul Benedict added a comment - Dennis, no, it is not related. MWAR-197 deals with missing manifest entries. This ticket deals with the entire manifest being absent from target/<WAR_EXPLODED_LOCATION>.
          Hide
          Dennis Lundberg added a comment -

          Paul, could you attach a small sample project with your configuration?

          Show
          Dennis Lundberg added a comment - Paul, could you attach a small sample project with your configuration?
          Hide
          Alix Warnke added a comment -

          Nothing has happened for three years. Could you please prioritize this issue?
          Currently we cannot see the revision number for web applications deployed from a development environment

          Show
          Alix Warnke added a comment - Nothing has happened for three years. Could you please prioritize this issue? Currently we cannot see the revision number for web applications deployed from a development environment

            People

            • Assignee:
              Unassigned
              Reporter:
              Paul Benedict
            • Votes:
              11 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated: