Details
Improvement
Closed
Major
Description
Quoting Hervé:
Maven filtering provides an encoding parameter to set encoding used when
reading/writing files. But war plugin uses null value, which means platform
encoding... Sorry, encoding support won't be totally "free"I added TODOs in the code.
For web.xml and container config XML file, I set encoding to UTF-8, which is a
better default value than platform encoding.For other filtered resources, you'll need to add an encoding attribute to
o.a.m.model.Resource class, to let the user define which encoding he wants to
use when filtering. Perhaps using project.build.sourceEncoding as a default
value is a good idea.
Seems like this is worth a Jira issue to track this new feature.
Issue Links
Activity
So we need to detect *.xml files (in a harcoded way ?).
This need some changes in DefaultMavenFileFilter#copyFile.
Something like
pseudo code without any formating 
if ( file.endWith (*.xml) )
encoding = ReaderFactory.newXmlReader( from ).getEncoding();
BTW this new way of filtering should be off by default (and configurable).
As this can break some builds.
WDYT ?
I was facing this problem in our builds as well, so I've worked around it by setting the JVM file.encoding-property.
It works for me, but not for my team, so I'd like to fix it permanently.
For now my preference is to keep the existing behaviour as default (which is odd, but well known). In my patch I've added a property named resourceEncoding to the AbstractWarMojo.
I've added this to my parent-poms:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-war-plugin</artifactId>
<version>2.2-SNAPSHOT</version>
<configuration>
<resourceEncoding>${project.build.sourceEncoding}</resourceEncoding>
</configuration>
</plugin>
In order to test this I've modified the web-resources-filtering-Integration-Test and hope this will pass the review 
Please find my patch attached to this bug-report.
Best regards,
Florian
I stumbled upon this issue today when using filteringDeploymentDescriptors.
Filtering the web.xml file should be able to use the encoding specified in the web.xml file itself. We specify ISO-8859-1 as the encoding in our web.xml, but it ends up scrambled into UTF-8 after being filtered.
This is our configuration:
<plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-war-plugin</artifactId> <version>2.1-alpha-2</version> <configuration> <archive> <manifest> <addDefaultImplementationEntries>true</addDefaultImplementationEntries> <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries> </manifest> </archive> <archiveClasses>true</archiveClasses> <filteringDeploymentDescriptors>true</filteringDeploymentDescriptors> </configuration> </plugin>