Maven WAR Plugin
  1. Maven WAR Plugin
  2. MWAR-150

Test for overlay.skip before resolving overlay dependency

    Details

    • Type: Improvement Improvement
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.1-alpha-1
    • Fix Version/s: None
    • Component/s: overlay
    • Labels:
      None
    • Number of attachments :
      1

      Description

      I have a "master" pom that many projects share and inherit common build, report, dependency, etc. functionality from. I would like all of my .war projects to inherit from this "master" pom including my overlays and my projects that use the overlay.

      In my master pom I have:

      		<pluginManagement>
      			<plugins>
      				<plugin>
      					<groupId>org.apache.maven.plugins</groupId>
      					<artifactId>maven-war-plugin</artifactId>
      					<version>2.1-alpha-1</version>
      					<configuration>
      						<overlays>
      							<overlay>
      								<groupId>com.mycompany.app</groupId>
      								<artifactId>my-overlay</artifactId>
      							</overlay>
      							<overlay></overlay>
      						</overlays>
      					</configuration>
      				</plugin>
      			</plugins>
      		</pluginManagement>
      

      This obviously causes a problem when the overlay war is created because it cannot overlay itself with itself. So I get the error:

      "overlay[ id com.mycompany.app:my-overlay] is not a dependency of the project."
      

      I tried overriding the war plugin in the overlay pom and removed the overlays but there seemed to be some kind of inheritance thing going on where the overlays were still being added no matter what I did. (Might be a different issue?)

      Anyway, another way to fix this issue might be to use the "skip" attribute??? But I get the same error using <skip>true</skip>. Would it be possible to allow the "skip" attribute to be tested prior to overlay dependency checking? I've provided an example project of how I would like skip to function in a clean way that might help this problem of circular overlays.

      Mike

        Activity

        Hide
        Jon Osborn added a comment -

        I was also able to confirm this. I think there are two issues: 1) inheritance doesn't seem to be working and 2) the overlay dependencies should be checked after the skip attribute.

        Also, I can't get an inherited or dependencyManagement dependency to get used in the overlay. I always have to fully qualify the dependency to get the overlay to work.

        Jon

        Show
        Jon Osborn added a comment - I was also able to confirm this. I think there are two issues: 1) inheritance doesn't seem to be working and 2) the overlay dependencies should be checked after the skip attribute. Also, I can't get an inherited or dependencyManagement dependency to get used in the overlay. I always have to fully qualify the dependency to get the overlay to work. Jon

          People

          • Assignee:
            Unassigned
            Reporter:
            Mike Youngstrom
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: