Maven 2.x WAR Plugin

Custom filter list does not work

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1-alpha-1
  • Fix Version/s: 2.1-alpha-2
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

When specifying filters on the plugin (not inside <project>) like this:

<configuration>
  <resource>
    <directory>polopoly-resources/config_ptest</directory>
    <targetPath>WEB-INF/config</targetPath>
  </resource>
  <warName>ptest</warName>
  <workDirectory>target/ptest-work</workDirectory>
  <filters>
    <filter>src/main/filters/filter.ptest.properties</filter>
  </filters>
<webResources>
  <resource>
    <directory>src/main/resources</directory>
    <targetPath>WEB-INF/classes</targetPath>
    <filtering>true</filtering>
  </resource>
</webResources>

the list of filters is ignored. If I move the <filters> list to inside the <project> they work as expected. The documentation explicitly say that this is possible under the section "Filtering webResources".

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Olivier Lamy added a comment -

Did you try on last SNAPSHOT ?
Concerning plugin configuration :

  <filters>
    <filter>src/main/filters/filter.ptest.properties</filter>
  </filters>

I would prefer something like 

  <filters>
    <filter>${basedir}/src/main/filters/filter.ptest.properties</filter>
  </filters>
Show
Olivier Lamy added a comment - Did you try on last SNAPSHOT ? Concerning plugin configuration : <filters> <filter> src/main/filters/filter.ptest.properties </filter> </filters> I would prefer something like <filters> <filter> ${basedir}/src/main/filters/filter.ptest.properties </filter> </filters>
Hide
Permalink
Trygve Laugstøl added a comment -

No, I haven't. If the latest SNAPSHOT fixes is, consider this a documentation bug as it should be specified with a "since" description.

Also, if $

{basedir}

really is required (if it is a File[] array it isn't), that is also a bug. All file references are always relative to the project itself.

Show
Trygve Laugstøl added a comment - No, I haven't. If the latest SNAPSHOT fixes is, consider this a documentation bug as it should be specified with a "since" description. Also, if $ {basedir} really is required (if it is a File[] array it isn't), that is also a bug. All file references are always relative to the project itself.
Hide
Permalink
Olivier Lamy added a comment -

fix in rev 628569.

Show
Olivier Lamy added a comment - fix in rev 628569.
Hide
Permalink
Trygve Laugstøl added a comment -

Verified, works like a charm!

Show
Trygve Laugstøl added a comment - Verified, works like a charm!

People

  • Assignee:
    Olivier Lamy
    Reporter:
    Trygve Laugstøl
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: