Maven 2.x WAR Plugin

War Overlays and resources filtering

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1-alpha-1
  • Fix Version/s: 2.1-alpha-2
  • Component/s: None
  • Labels:
    None
  • Environment:
    maven 2.0.7
  • Number of attachments :
    2

Description

I have multiple web applications who share common resources.
So I use the war overlays mechanism.

All seems ok except for common properties files that I want to filter when creating the web applications.
For instance (see war-overlays-filter.zip in attachment):
My war-common war
war-common.war

– WEB-INF\classes\filter.properties (which contains for instance title.main=Prototype $ {pom.name}

)

I would like to create the war-filter-overlay web application
war-filter-overlay.war

– WEB-INF\classes\filter.properties (which contains the filtering property title.main=Prototype war-filter-overlay)

As suggested by Olivier Lamy it tried this configuration

 
      <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-war-plugin</artifactId>
          <version>2.1-alpha-2-SNAPSHOT</version>
          <!--version>2.1-alpha-1</version-->
          <!--version>2.0.2</version-->
          <configuration>
            <overlays>
              <overlay>
                <groupId>debug.war</groupId>
                <artifactId>common-overlay</artifactId>
                <!--targetPath>filter</targetPath-->
                <filtered>true</filtered>
              </overlay>
            </overlays>
        </configuration>
      </plugin>

Unfortunately it's not working.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Olivier Lamy added a comment -

fix in rev 620614.

Show
Olivier Lamy added a comment - fix in rev 620614.
Hide
Permalink
Rémy Sanlaville added a comment -

It works great !
It would be nice also to update the documentation in order to reflect this improvement.

Many thanks Olivier

Show
Rémy Sanlaville added a comment - It works great ! It would be nice also to update the documentation in order to reflect this improvement. Many thanks Olivier
Hide
Permalink
Rémy Sanlaville added a comment -

Unfortunately, I have to reopen the issue.

In fact, I have a strange behavior when using filtering war overlays and multi-level structure project.
To be more precise, l have a two level structure project as this :

project
| -- mod2
|     | -- war-overlay-filter
| -- war-common

If I launch mvn clean package at the mod2 or war-overlay-filter level it does work.
But on the other hand, If I launch mvn clean package at the root project level it does not work.

You will find in attachment a new example project (reactor-war-overlay-filter.zip) in order to reproduce the problem.

For information, I also try with a simple jar project to see I have the same behavior, but it works (even with a multi-level structure project). So the problem seems to not come from the maven-resource-plugin.

Show
Rémy Sanlaville added a comment - Unfortunately, I have to reopen the issue. In fact, I have a strange behavior when using filtering war overlays and multi-level structure project. To be more precise, l have a two level structure project as this : project | -- mod2 | | -- war-overlay-filter | -- war-common If I launch mvn clean package at the mod2 or war-overlay-filter level it does work. But on the other hand, If I launch mvn clean package at the root project level it does not work. You will find in attachment a new example project (reactor-war-overlay-filter.zip) in order to reproduce the problem. For information, I also try with a simple jar project to see I have the same behavior, but it works (even with a multi-level structure project). So the problem seems to not come from the maven-resource-plugin.
Hide
Permalink
Rémy Sanlaville added a comment -

New example in order to reproduce the problem with a multi-level project structure

Show
Rémy Sanlaville added a comment - New example in order to reproduce the problem with a multi-level project structure
Hide
Permalink
Olivier Lamy added a comment -

remove the war plugin version (2.0.2) from your war-common pom.
Here it's more a mvn issue (looks similar to MNG-1024)

Show
Olivier Lamy added a comment - remove the war plugin version (2.0.2) from your war-common pom. Here it's more a mvn issue (looks similar to MNG-1024 )
Hide
Permalink
Rémy Sanlaville added a comment -

Thanks Olivier, you have right and it works great.
It seems effectively related to MNG-1024

Show
Rémy Sanlaville added a comment - Thanks Olivier, you have right and it works great. It seems effectively related to MNG-1024

People

  • Assignee:
    Olivier Lamy
    Reporter:
    Rémy Sanlaville
Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: