ClasscastException when turning filtering on the web resources

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0.2
Fix Version/s: 2.1-alpha-2
Component/s: None
Labels:
None
Environment:
Maven 2.0.8, Win XP

Number of attachments :
0

Description

Hello,

I have configured the maven-war-plugin to filter my files in src/main/webapp, in particular web.xml.

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-war-plugin</artifactId>
<configuration>
<archive>
<addMavenDescriptor>
false
</addMavenDescriptor>
</archive>
<webResources>
<resource>
<filtering>true</filtering>
<directory>
src/main/webapp
</directory>
<includes>
<include>*/</include>
</includes>
</resource>
</webResources>
</configuration>
</plugin>

But when I run Maven, I get the following error:

[INFO] Copy webapp webResources to [...]\client-framework-webapp-0.2-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[ERROR] FATAL ERROR
[INFO] ------------------------------------------------------------------------
[INFO] org.apache.maven.project.MavenProject
[INFO] ------------------------------------------------------------------------
[INFO] Trace
java.lang.ClassCastException: org.apache.maven.project.MavenProject
at org.codehaus.plexus.util.InterpolationFilterReader.read(InterpolationFilterReader.java:269)
at org.codehaus.plexus.util.InterpolationFilterReader.read(InterpolationFilterReader.java:162)
at java.io.Reader.read(Reader.java:100)
at org.codehaus.plexus.util.IOUtil.copy(IOUtil.java:212)
at org.codehaus.plexus.util.IOUtil.copy(IOUtil.java:200)
at org.apache.maven.plugin.war.AbstractWarMojo.copyFilteredFile(AbstractWarMojo.java:921)
at org.apache.maven.plugin.war.AbstractWarMojo.copyResources(AbstractWarMojo.java:415)
at org.apache.maven.plugin.war.AbstractWarMojo.buildWebapp(AbstractWarMojo.java:518)
at org.apache.maven.plugin.war.AbstractWarMojo.buildExplodedWebapp(AbstractWarMojo.java:347)
at org.apache.maven.plugin.war.WarMojo.performPackaging(WarMojo.java:164)
at org.apache.maven.plugin.war.WarMojo.execute(WarMojo.java:130)
at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:447)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:480)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:459)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:278)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:333)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:126)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:282)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
[INFO] ------------------------------------------------------------------------

Any idea?

Thanks,
Ludovic

Issue Links

is duplicated by

MWAR-109 Problem using webResources in configuration

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Ludovic Claude added a comment - 06/Dec/07 12:41 PM

I did a bit of debugging, so here are my results:

the filter scans all files in src/main/webapp, and this includes JSP pages with tags like <%@ taglib ... />
in InterpolationFilterReader.read(), the key value is "@", and the variableKey is ""
for some reason, variables.get("") returns a MavenProject instance

In fact, the problem comes from the fact that plexus.utils 1.0.2 is used by the war plugin, while a more recent version of plexus.utils such as 1.2 doesn't try to cast directly the value returned by variables.get() to a String.

So the fix is quite simple here: use plexus 1.2 or better!

Show

Ludovic Claude added a comment - 06/Dec/07 12:41 PM I did a bit of debugging, so here are my results: the filter scans all files in src/main/webapp, and this includes JSP pages with tags like <%@ taglib ... /> in InterpolationFilterReader.read(), the key value is "@", and the variableKey is "" for some reason, variables.get("") returns a MavenProject instance In fact, the problem comes from the fact that plexus.utils 1.0.2 is used by the war plugin, while a more recent version of plexus.utils such as 1.2 doesn't try to cast directly the value returned by variables.get() to a String. So the fix is quite simple here: use plexus 1.2 or better!

Hide

Permalink

Olivier Lamy added a comment - 06/Dec/07 4:20 PM

Hi,
Can we know which version of the plugin you are using ?
As I see in the stackTrace it looks to be an old and in the last release we use p-u 1.4.7.
Can you try 2.1-alpha-1 ? or the current trunk ?
Thanks,
–
Olivier

Show

Olivier Lamy added a comment - 06/Dec/07 4:20 PM Hi, Can we know which version of the plugin you are using ? As I see in the stackTrace it looks to be an old and in the last release we use p-u 1.4.7. Can you try 2.1-alpha-1 ? or the current trunk ? Thanks, – Olivier

Hide

Permalink

Ludovic Claude added a comment - 07/Dec/07 4:20 AM

Hello Olivier,

I'm using version 2.0.2 of the war plugin. If I upgrade to 2.1-alpha-1, then the build doesn't fail any more, but it still doesn't do what I want:

I have the following line in my web.xml file:

<display-name>Myapp version $

{app.version} - Login module </display-name>

In a paren POM, app.version is set to 7, while the current project version is 0.2-snapshot. Now the filter replaces ${app.version}

with the value of $

{version}

or $

{project.version}

...

<display-name>Myapp version 0.2-SNAPSHOT - Login module </display-name>

So it looks like I'm hitting now the ~~MWAR-133~~ issue...

Thanks for your help,
Ludovic

Show

Ludovic Claude added a comment - 07/Dec/07 4:20 AM Hello Olivier, I'm using version 2.0.2 of the war plugin. If I upgrade to 2.1-alpha-1, then the build doesn't fail any more, but it still doesn't do what I want: I have the following line in my web.xml file: <display-name>Myapp version $ {app.version} - Login module </display-name> In a paren POM, app.version is set to 7, while the current project version is 0.2-snapshot. Now the filter replaces ${app.version} with the value of $ {version} or $ {project.version} ... <display-name>Myapp version 0.2-SNAPSHOT - Login module </display-name> So it looks like I'm hitting now the MWAR-133 issue... Thanks for your help, Ludovic

Hide

Permalink

Ludovic Claude added a comment - 07/Dec/07 4:51 AM

Update: I had this filtering issue because some developer put png images in the src/main/webapp folder. Once they are removed, then the filtering kind of works, if it were not for the issue mentioned above.

Ludovic.

Show

Ludovic Claude added a comment - 07/Dec/07 4:51 AM Update: I had this filtering issue because some developer put png images in the src/main/webapp folder. Once they are removed, then the filtering kind of works, if it were not for the issue mentioned above. Ludovic.

Hide

Permalink

St�phane Nicoll added a comment - 09/Feb/08 11:31 AM

Hey Olivier,

Do you think that kind of issues is now fixed with the new filtering implementation?

Show

St�phane Nicoll added a comment - 09/Feb/08 11:31 AM Hey Olivier, Do you think that kind of issues is now fixed with the new filtering implementation?

Hide

Permalink

Olivier Lamy added a comment - 09/Feb/08 4:18 PM

I should say yes .

Show

Olivier Lamy added a comment - 09/Feb/08 4:18 PM I should say yes .

Hide

Permalink

Olivier Lamy added a comment - 15/Feb/08 4:41 PM

fixed with using maven-filtering component

Show

Olivier Lamy added a comment - 15/Feb/08 4:41 PM fixed with using maven-filtering component

People

Assignee:

Olivier Lamy

Reporter:

Ludovic Claude

Vote (0)

Watch (2)

Dates

Created:

06/Dec/07 12:09 PM

Updated:

15/Feb/08 4:41 PM

Resolved:

15/Feb/08 4:41 PM