Maven 2.x Versions Plugin

allowMajorUpdates=false and allowSnapshots=true interfere

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: Backlog
  • Fix Version/s: None
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    2

Description

When setting 'allowMajorUpdates' to 'false' and 'allowSnapshots' to 'true', '1.0' will still be upgraded to '2.0-SNAPSHOT', presumable because it is considered to be below the 'upper bound' of '2.0'.

This is obviously undesirable because setting 'allowMajorUpdates' to 'false' is likely to be intended to prevent upgrading to a version with API-breaking changes, and '2.0-SNAPSHOT' may already hold those API-breaking changes.

Attached is a patch that adds a unit test showing the behavior.

  1. Text File
    noMajorUpdates.patch
    27/Sep/11 10:43 AM
    3 kB
    Arnout Engelen
  2. Text File
    noMajorUpdatesTest.patch
    27/Sep/11 10:17 AM
    2 kB
    Arnout Engelen

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Arnout Engelen added a comment -

Patch that should fix the issue.

Not sure what to do with the PropertyVersionComparator inside PropertyVersions, but this does pass all unit tests and produces the behavior I expected.

Show
Arnout Engelen added a comment - Patch that should fix the issue. Not sure what to do with the PropertyVersionComparator inside PropertyVersions, but this does pass all unit tests and produces the behavior I expected.
Arnout Engelen made changes -
Field Original Value New Value
Attachment noMajorUpdates.patch [ 57051 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Arnout Engelen
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: