Maven 2.x Versions Plugin

versions:set is not propagated to submodules if they don't inherit aggregator pom

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.1, 1.2
  • Fix Version/s: None
  • Labels:
    None
  • Environment:
    Maven 2.2.1
  • Number of attachments :
    2

Description

If we have a project A with modules B & C where :

  • B inherit from A
  • C DOESN'T inherit from A

When we execute the following command line :
mvn org.codehaus.mojo:versions-maven-plugin:1.2:set -DnewVersion=0.1

Only A & B are updated.
The fact that C doesn't inherit from A (whereas C is a module of A) doesn't make it updated.

  1. Text File
    MVERSIONS-131_patch.txt
    13/Mar/12 7:05 PM
    7 kB
    Daniel Johnson

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MVERSIONS-115 Missing version update inside dependency

  • Major - Major loss of function.
  • Reopened - This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.

Activity

Ascending order - Click to sort in descending order
Stephen Connolly made changes -
Field Original Value New Value
Link This issue relates to MVERSIONS-115 [ MVERSIONS-115 ]
Hide
Permalink
Daniel Johnson added a comment -

This has been a long standing problem for me as well. Has anyone been able to find a work-around? It does not make sense to me why this only works when the children specify the aggregator/reactor as the parent POM. Curious if it is a limitation, or a missed corner case in the code.

Show
Daniel Johnson added a comment - This has been a long standing problem for me as well. Has anyone been able to find a work-around? It does not make sense to me why this only works when the children specify the aggregator/reactor as the parent POM. Curious if it is a limitation, or a missed corner case in the code.
Hide
Permalink
Daniel Johnson added a comment - - edited

Here is a proposed patch MVERSIONS-131_patch.txt. The change is to simply update all projects which had the same version to start with as the reactor/aggregator POM. If the reactor/aggregator POM is the <parent> the parent version is also updated as before, but essentially it simplifies the logic by just updating all projects with the same version instead of only those projects where the parent was the reactor.

All unit tests still pass with this patch, but I did not check what the unit tests are actually testing...

Show
Daniel Johnson added a comment - - edited Here is a proposed patch MVERSIONS-131_patch.txt . The change is to simply update all projects which had the same version to start with as the reactor/aggregator POM. If the reactor/aggregator POM is the <parent> the parent version is also updated as before, but essentially it simplifies the logic by just updating all projects with the same version instead of only those projects where the parent was the reactor. All unit tests still pass with this patch, but I did not check what the unit tests are actually testing...
Daniel Johnson made changes -
Attachment MVERSIONS-131_patch.txt [ 59200 ]
Hide
Permalink
Fernando Padilla added a comment -

Yes, this is hitting me right now and would love to get this fixed!

Show
Fernando Padilla added a comment - Yes, this is hitting me right now and would love to get this fixed!
Hide
Permalink
Michal Kroliczek added a comment -

Oh i spent couple hours on that, event prepared test case and then found it
Please fix it.

Show
Michal Kroliczek added a comment - Oh i spent couple hours on that, event prepared test case and then found it Please fix it.
Hide
Permalink
Frank Schönheit added a comment -

could any of the (core) developers please common whether

  • this is an accepted bug (i.e. intended to be fixed)
  • the attached patch is a legitimate and viable solution
  • there are any plans in which version this might be fixed?

(We're in need of this feature, too, and I'm trying to get a feeling how far we are from getting it )

Thanks.

Show
Frank Schönheit added a comment - could any of the (core) developers please common whether this is an accepted bug (i.e. intended to be fixed) the attached patch is a legitimate and viable solution there are any plans in which version this might be fixed? (We're in need of this feature, too, and I'm trying to get a feeling how far we are from getting it ) Thanks.

People

  • Assignee:
    Unassigned
    Reporter:
    Frédéric Camblor
Vote (6)
Watch (6)

Dates

  • Created:
    Updated: