MVEL

Bug calling static methods with expressions as params

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.2.6
  • Fix Version/s: 1.2.7
  • Component/s: Parser
  • Labels:
    None
  • Environment:
    jdk 1.5
  • Testcase included:
    yes
  • Number of attachments :
    2

Description

When I call a static method with an expression as param, like this:

mvel.test.AStatic.process(value)

where value is a field of a given pojo, I receive the following exception

org.mvel.PropertyAccessException: unable to resolve property: failed to access property: <<mvel.test.AStatic.process(value)>> in: class mvel.test.PojoStatic
at org.mvel.PropertyAccessor.get(PropertyAccessor.java:182)
at org.mvel.PropertyAccessor.get(PropertyAccessor.java:131)
at org.mvel.ASTNode.getReducedValue(ASTNode.java:256)
at org.mvel.MVELInterpretedRuntime.parseAndExecuteInterpreted(MVELInterpretedRuntime.java:110)
at org.mvel.MVELInterpretedRuntime.parse(MVELInterpretedRuntime.java:58)
at org.mvel.MVEL.eval(MVEL.java:127)
at mvel.test.StaticMvelTest.testStaticWithExpressionParam(StaticMvelTest.java:25)
Caused by: org.mvel.PropertyAccessException: unable to resolve property: could not access property (mvel)
at org.mvel.PropertyAccessor.getBeanProperty(PropertyAccessor.java:442)
at org.mvel.PropertyAccessor.get(PropertyAccessor.java:156)
... 28 more

I've attached a testcase to reproduce it

Thanks in advance

German.-

  1. GZip Archive
    static.tar.gz
    28/Sep/07 9:11 AM
    0.6 kB
    German de la Cruz
  2. GZip Archive
    static-version-2.tar.gz
    28/Sep/07 5:48 PM
    0.7 kB
    German de la Cruz

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mike Brock added a comment -

The test-case you submitted is in error itself. In your class, AStatic, the method call is "Process" with an uppercase P. However, note in your testcase here:

@Test
public void testStaticWithExpressionParam(){
	PojoStatic pojo=new PojoStatic("10");
	MVEL.eval("mvel.test.AStatic.process(value)", pojo, new HashMap() );
}

... you are calling "process" with a lower case P. All method calls in MVEL (like Java) are case sensitive. If you correct the code accordingly, it passes fine.

Show
Mike Brock added a comment - The test-case you submitted is in error itself. In your class, AStatic, the method call is "Process" with an uppercase P. However, note in your testcase here: @Test public void testStaticWithExpressionParam(){ PojoStatic pojo= new PojoStatic( "10" ); MVEL.eval( "mvel.test.AStatic.process(value)" , pojo, new HashMap() ); } ... you are calling "process" with a lower case P. All method calls in MVEL (like Java) are case sensitive. If you correct the code accordingly, it passes fine.
Hide
Permalink
German de la Cruz added a comment -

Ok, my mistake, my test wasn't good enough.

Now, I can reproduce it ok. It seems this type of expressions

value!=null && mvel.test.AStatic.Process(value.toString())
or
value!=null && mvel.test.AStatic.Process(member.toString())

work ok, but this

value!=null && mvel.test.AStatic.Process(value.toString().toString())
value!=null && mvel.test.AStatic.Process(member.value.toString())

don't!. It's really weird, because there is only one more method call. Where there are two method calls it works ok, but 3 or more method calls make it fail!

I'll attach a new testcase (version 2)

Thanks!

Show
German de la Cruz added a comment - Ok, my mistake, my test wasn't good enough. Now, I can reproduce it ok. It seems this type of expressions value!=null && mvel.test.AStatic.Process(value.toString()) or value!=null && mvel.test.AStatic.Process(member.toString()) work ok, but this value!=null && mvel.test.AStatic.Process(value.toString().toString()) value!=null && mvel.test.AStatic.Process(member.value.toString()) don't!. It's really weird, because there is only one more method call. Where there are two method calls it works ok, but 3 or more method calls make it fail! I'll attach a new testcase (version 2) Thanks!
Hide
Permalink
German de la Cruz added a comment -

This is the version 2

Show
German de la Cruz added a comment - This is the version 2
Hide
Permalink
Mike Brock added a comment -

Fixed in trunk.

Show
Mike Brock added a comment - Fixed in trunk.
Hide
Permalink
Mike Brock added a comment -

Thanks. This is fixed in SVN.

Show
Mike Brock added a comment - Thanks. This is fixed in SVN.
Hide
Permalink
German de la Cruz added a comment -

Thank you very much!

It works great.

Show
German de la Cruz added a comment - Thank you very much! It works great.

People

  • Assignee:
    Mike Brock
    Reporter:
    German de la Cruz
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: