Trailing ORB tag start character in expression triggers ArrayIndexOutOfBoundsException in TemplateCompiler

TemplateCompiler has incorrect bounds checking, which causes the following test to fail on the third evaluation:

@Test
public void expandStrangeValue()

{ TemplateRuntime.eval("test", Collections.emptyMap()); TemplateRuntime.eval("test$ ", Collections.emptyMap()); TemplateRuntime.eval("test$", Collections.emptyMap()); }

The problem is likely caused by the bounds checking in TemplateCompiler. The current implementation is:

public boolean isNext(char c)

{ return cursor != length && template[cursor + 1] == c; }

The correct implementation should probably be:

public boolean isNext(char c)

{ return cursor != (length - 1) && template[cursor + 1] == c; }