Maven 2.x Tomcat Plugin

Allow to deploy assembled wars

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-beta-1
  • Fix Version/s: 1.0
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    0

Description

We are assembling our wars with the assembly plugin in a project that has pom packaging so we can not use the tomcat plugin to deploy our wars.

Pls. allow to configure overwriting the isWar() functionality checking the packaging:
E.G. change AbstractRunMojo.java with (i am not familiar with the patch format so here inline

/**
 * If set to true ignore if packaging of project is not 'war'.
 * 
 * @parameter expression="false"
 */
private boolean ignorePackaging;

221     /**
222      * Gets whether this project uses WAR packaging or if it shoud be ignored.
223      * 
224      * @return whether this project uses WAR packaging or if it should be ignored.
225      */
226     protected boolean isWar()
227     {
228         return "war".equals( packaging ) || ignorePackaging;
229     }

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ulrich David added a comment -

Sorry, but i did not recognized, that confluence formating is used so:

// after line 112
/**
 * If set to true ignore if packaging of project is not 'war'.
 *
 * @parameter expression="false"
*/
private boolean ignorePackaging;

// lines 221-229
/**
* Gets whether this project uses WAR packaging or if it shoud be ignored.
*
* @return whether this project uses WAR packaging or if it should be ignored.
*/
protected boolean isWar()
{ 
    return "war".equals( packaging ) || ignorePackaging;
}
Show
Ulrich David added a comment - Sorry, but i did not recognized, that confluence formating is used so: // after line 112 /** * If set to true ignore if packaging of project is not 'war'. * * @parameter expression= " false " */ private boolean ignorePackaging; // lines 221-229 /** * Gets whether this project uses WAR packaging or if it shoud be ignored. * * @ return whether this project uses WAR packaging or if it should be ignored. */ protected boolean isWar() { return "war" .equals( packaging ) || ignorePackaging; }
Hide
Permalink
Dennis Lundberg added a comment -

Add formating.

Show
Dennis Lundberg added a comment - Add formating.
Hide
Permalink
Simone Gianni added a comment -

Moreover the code looks for packaging.equals("war"), this makes it impossible to make it work with alternative packagings that still produce a war. If I understand it correctly, I think it should check for type.equals("war"), which anyway works with the default packaging, as described here http://docs.codehaus.org/display/MAVEN/Packaging+vs+Type+-+Derived+and+Attached+Artifacts .

Show
Simone Gianni added a comment - Moreover the code looks for packaging.equals("war"), this makes it impossible to make it work with alternative packagings that still produce a war. If I understand it correctly, I think it should check for type.equals("war"), which anyway works with the default packaging, as described here http://docs.codehaus.org/display/MAVEN/Packaging+vs+Type+-+Derived+and+Attached+Artifacts .
Hide
Permalink
Olivier Lamy added a comment -

rev 12066
Thanks

Show
Olivier Lamy added a comment - rev 12066 Thanks

People

  • Assignee:
    Olivier Lamy
    Reporter:
    Ulrich David
Vote (2)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: