Mojo's SQL Maven Plugin
  1. Mojo's SQL Maven Plugin
  2. MSQL-72

forceMojoExecution parameter changed to forceOpenJpaExecution?

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Not A Bug
    • Affects Version/s: 1.4
    • Fix Version/s: None
    • Labels:
      None
    • Number of attachments :
      0

      Description

      Running Maven with -DforceMojoExecution does not seem to do anything. -DforceOpenJpaExecution causes the plugin to be executed. I assume that is a mistake, but if it isn't, the documentation should be updated, shouldn't it?

        Activity

        Hide
        Tom Snee added a comment -

        To clarify, "forceMojoExecution" works as a pom configuration element but not as a command line parameter. "forceOpenJpaExecution" works from the command line but not in the pom.

        Show
        Tom Snee added a comment - To clarify, "forceMojoExecution" works as a pom configuration element but not as a command line parameter. "forceOpenJpaExecution" works from the command line but not in the pom.
        Hide
        Mark Struberg added a comment - - edited

        Sorry, I have no clue what you are talking about

        Which mojo, how does your pom look like, etc....

        edit
        Do you mean that this works well but you would additionally like to force this on the commandline?

        Show
        Mark Struberg added a comment - - edited Sorry, I have no clue what you are talking about Which mojo, how does your pom look like, etc.... edit Do you mean that this works well but you would additionally like to force this on the commandline?
        Hide
        Tom Snee added a comment - - edited

        Sorry, I thought MSQL-* issues were always for maven-sql-plugin, whose only mojo is "execute".

        edit
        What I mean is, the following command-line does nothing:
        mvn -Dforce*Mojo*Execution sql:execute
        Here is what must be typed at the CLI:
        mvn -Dforce*OpenJpa*Execution sql:execute

        The documentation says nothing about "forceOpenJpaExecution", so either the documentation should be updated to say "use forceMojoExecution in the pom and forceOpenJpaExecution on the command line," which would be confusing, or the mojo's system-property-reading code should be fixed.

        Show
        Tom Snee added a comment - - edited Sorry, I thought MSQL-* issues were always for maven-sql-plugin, whose only mojo is "execute". edit What I mean is, the following command-line does nothing: mvn -Dforce*Mojo*Execution sql:execute Here is what must be typed at the CLI: mvn -Dforce*OpenJpa*Execution sql:execute The documentation says nothing about "forceOpenJpaExecution", so either the documentation should be updated to say "use forceMojoExecution in the pom and forceOpenJpaExecution on the command line," which would be confusing, or the mojo's system-property-reading code should be fixed.
        Hide
        Robert Scholte added a comment -

        Tom, it is.

        You seem to refer to http://mojo.codehaus.org/sql-maven-plugin/execute-mojo.html#forceMojoExecution
        Names of the parameters, in this case (forceMojoExecution), are used inside the plugin configuration.
        Expressions, in this case forceOpenJpaExecution, are used from commandLine like -DforceOpenJpaExecution=true

        But looking at the names it's a bit strange that they are different...

        Show
        Robert Scholte added a comment - Tom, it is. You seem to refer to http://mojo.codehaus.org/sql-maven-plugin/execute-mojo.html#forceMojoExecution Names of the parameters, in this case ( forceMojoExecution ), are used inside the plugin configuration. Expressions, in this case forceOpenJpaExecution , are used from commandLine like -DforceOpenJpaExecution=true But looking at the names it's a bit strange that they are different...
        Hide
        Tom Snee added a comment -

        Thank you for explaining that. I have never seen a parameter with a different expression on the command line, so until now I was not even aware that they could be different.

        Here on in, I will pay closer attention to the "Expression" field in the docs.

        Show
        Tom Snee added a comment - Thank you for explaining that. I have never seen a parameter with a different expression on the command line, so until now I was not even aware that they could be different. Here on in, I will pay closer attention to the "Expression" field in the docs.
        Hide
        Robert Scholte added a comment -

        Closing it. Just a little misunderstanding of expressions.

        Show
        Robert Scholte added a comment - Closing it. Just a little misunderstanding of expressions.

          People

          • Assignee:
            Robert Scholte
            Reporter:
            Tom Snee
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: