Maven 2.x Source Plugin

Attached source artifact should not be added for artifacts with classifier

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.1
  • Fix Version/s: 2.0.2
  • Labels:
    None
  • Number of attachments :
    0

Description

If the main artifact has a classifier then we shouldn't attach a source artifact to it as Maven2 only allows one classifier. Doing the attachment leads to errors such as:

[INFO] Installing C:\dev\maven\trunks\plugins\maven-clover-plugin\src\it\usertest\target\clover\maven-clover-plugin-sample-usertest-1.0-SNAPSHOT-clover.jar to C:\Documents and Settings\vmassol\.m2\repository\org\apache\maven\plugins\maven-clover-plugin-sample-usertest\1.0-SNAPSHOT\maven-clover-plugin-sample-usertest-1.0-SNAPSHOT-clover.jar
[INFO] Installing C:\dev\maven\trunks\plugins\maven-clover-plugin\src\it\usertest\target\maven-clover-plugin-sample-usertest-1.0-SNAPSHOT-sources.jar to C:\Documents and Settings\vmassol\.m2\repository\org\apache\maven\plugins\maven-clover-plugin-sample-usertest\1.0-SNAPSHOT\maven-clover-plugin-sample-usertest-1.0-SNAPSHOT-sources.jar
[INFO] Installing C:\dev\maven\trunks\plugins\maven-clover-plugin\src\it\usertest\target\clover\maven-clover-plugin-sample-usertest-1.0-SNAPSHOT-clover-sources.jar to C:\Documents and Settings\vmassol\.m2\repository\org\apache\maven\plugins\maven-clover-plugin-sample-usertest\1.0-SNAPSHOT\maven-clover-plugin-sample-usertest-1.0-SNAPSHOT-sources.jar

In the last line, notice the double classifier "-clover-sources" and the wrong destination "-sources".

Issue Links

relates to

New Feature - A new feature of the product, which has yet to be developed. MNG-2596 Allow support for multiple classifier for a given artifact

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vincent Massol added a comment -

Done. Leaving open for a few days to see if there's any reaction to my patch...

Show
Vincent Massol added a comment - Done. Leaving open for a few days to see if there's any reaction to my patch...
Hide
Permalink
Vincent Massol added a comment -

Closing for now

Show
Vincent Massol added a comment - Closing for now
Hide
Permalink
Peter Lynch added a comment -

I think this patch highlights a nasty side effect. Of course since classifier use is loosely defined, these leads to all sorts of bad plugin behavior when it comes to using classifiers.

To be more percise, how about building a war file with classifiers of dev, qa and prod.

With this patch there is no way to distinguish between dev,qa and prod sources, yet the final war file name can be deployed as

myproject-1.0.0-dev.war

Where 'dev' is the war plugin classifier. When sources get deployed for prod,qa and dev, they will override each other in the repo

myproject-1.0.0-sources.war

So you'll never know what sources you got by the filename.

The only work around I see is to avoid the use of classifier all together and make the version something like

<version>1.0.0-dev</version>

which means SNAPSHOT version has to be

<version>1.0.0-dev-SNAPSHOT</version>

because "-SNAPSHOT" needs to be at the end of the version string. And to depend on this in another pom becomes (notice no classifier)

<dependency>
<artifactId>myproject</artifactId>
<groupId>myproject</groupId>
<version>1.0.0-dev</version>
</dependency>

-Peter

Show
Peter Lynch added a comment - I think this patch highlights a nasty side effect. Of course since classifier use is loosely defined, these leads to all sorts of bad plugin behavior when it comes to using classifiers. To be more percise, how about building a war file with classifiers of dev, qa and prod. With this patch there is no way to distinguish between dev,qa and prod sources, yet the final war file name can be deployed as myproject-1.0.0-dev.war Where 'dev' is the war plugin classifier. When sources get deployed for prod,qa and dev, they will override each other in the repo myproject-1.0.0-sources.war So you'll never know what sources you got by the filename. The only work around I see is to avoid the use of classifier all together and make the version something like <version>1.0.0-dev</version> which means SNAPSHOT version has to be <version>1.0.0-dev-SNAPSHOT</version> because "-SNAPSHOT" needs to be at the end of the version string. And to depend on this in another pom becomes (notice no classifier) <dependency> <artifactId>myproject</artifactId> <groupId>myproject</groupId> <version>1.0.0-dev</version> </dependency> -Peter

People

  • Assignee:
    Vincent Massol
    Reporter:
    Vincent Massol
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: