jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
Signup
Mojo's Sonar Maven Plugin
  • Mojo's Sonar Maven Plugin
  • MSONAR-10

Sonar: support Maven 3

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

The version 1.0-beta-1 only supports Maven 2.x.
The branch sonar-maven-plugin-mvn-3.x adds the support of Maven 3.

Issue Links

depends upon

Improvement - An improvement or enhancement to an existing feature or task. SONAR-1851 Support Maven 3.0 final

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Improvement - An improvement or enhancement to an existing feature or task. SONAR-1265 Compatibility with Maven 3.0

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Improvement - An improvement or enhancement to an existing feature or task. SONAR-1772 Remove the use of the Maven Findbugs plugin to directly pilot the Findbugs library

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Simon Brandhof made changes - 20/Jul/10 5:39 PM
Field Original Value New Value
Assignee Simon Brandhof [ simon.brandhof ]
Evgeny Mandrikov made changes - 09/Aug/10 8:13 PM
Link This issue is depended upon by SONARIDE-62 [ SONARIDE-62 ]
Evgeny Mandrikov made changes - 09/Aug/10 8:13 PM
Link This issue is related to SONARIDE-62 [ SONARIDE-62 ]
Evgeny Mandrikov made changes - 09/Aug/10 8:13 PM
Link This issue is depended upon by SONARIDE-62 [ SONARIDE-62 ]
Hide
Permalink
Anders Hammar added a comment - 10/Aug/10 1:05 AM

As there is no fix version assigned, I'm wondering what version of the mojo this is targetting? On the the Sonar users mailing list, Evgeny Mandrikov answered "next version of the mojo". Would that be v2.0?
As Maven 3 is quite stable (and better than any of the version of Maven 2 IMO), it would be great to have the mojo support Maven 3 soon.

Show
Anders Hammar added a comment - 10/Aug/10 1:05 AM As there is no fix version assigned, I'm wondering what version of the mojo this is targetting? On the the Sonar users mailing list, Evgeny Mandrikov answered "next version of the mojo". Would that be v2.0? As Maven 3 is quite stable (and better than any of the version of Maven 2 IMO), it would be great to have the mojo support Maven 3 soon.
Hide
Permalink
Simon Brandhof added a comment - 31/Aug/10 2:45 AM

FYI the committed code supports maven 3.0-beta-2 but not 3.0-beta-3. It's preferable to wait for the final maven release in order to fix this issue.

Show
Simon Brandhof added a comment - 31/Aug/10 2:45 AM FYI the committed code supports maven 3.0-beta-2 but not 3.0-beta-3. It's preferable to wait for the final maven release in order to fix this issue.
Hide
Permalink
Olivier Lamy added a comment - 31/Aug/10 2:49 AM

IMHO this won't change .
I have done similar changes for maven site plugin. Do you want I apply same here ?

Show
Olivier Lamy added a comment - 31/Aug/10 2:49 AM IMHO this won't change . I have done similar changes for maven site plugin. Do you want I apply same here ?
Hide
Permalink
Simon Brandhof added a comment - 31/Aug/10 3:00 AM

Personally I stop working on this issue until the first RC, but of course your changes are welcome.
Thank you very much.

Show
Simon Brandhof added a comment - 31/Aug/10 3:00 AM Personally I stop working on this issue until the first RC, but of course your changes are welcome. Thank you very much.
Hide
Permalink
Anders Hammar added a comment - 31/Aug/10 3:20 AM

Simon,
I understand your position, but I kindly ask you to please keep up with the betas. The core API should be very stable, but there is a difference between beta-2 and beta-3 as you've spotted. However, the Maven team is very responsive so you should not have any problems getting help (as you've noticed by Olivier's comment).
Also, keeping up with the betas makes it possible to spot issues that can be fixed to ensure that Maven 3 will be the best version ever. Not doing this until a RC would delay the release of 3.0-final should you encounter a bug (or a 3.0-final version that doesn't work with the sonar plugin).

Show
Anders Hammar added a comment - 31/Aug/10 3:20 AM Simon, I understand your position, but I kindly ask you to please keep up with the betas. The core API should be very stable, but there is a difference between beta-2 and beta-3 as you've spotted. However, the Maven team is very responsive so you should not have any problems getting help (as you've noticed by Olivier's comment). Also, keeping up with the betas makes it possible to spot issues that can be fixed to ensure that Maven 3 will be the best version ever. Not doing this until a RC would delay the release of 3.0-final should you encounter a bug (or a 3.0-final version that doesn't work with the sonar plugin).
Hide
Permalink
Evgeny Mandrikov added a comment - 31/Aug/10 5:33 AM

Just my 2 cents: I'd like to have support for 3.0-beta-3 and drop support of 3.0-beta-2.

Show
Evgeny Mandrikov added a comment - 31/Aug/10 5:33 AM Just my 2 cents: I'd like to have support for 3.0-beta-3 and drop support of 3.0-beta-2.
Hide
Permalink
Olivier Lamy added a comment - 31/Aug/10 7:11 AM

So I have made changes locally.
I have the issue :

Caused by: org.sonatype.aether.transfer.ArtifactNotFoundException: 
Could not find artifact org.codehaus.sonar.runtime:sonar-core-maven3-plugin:jar:20100720181619

And I don't know where to find this plugin ? Any Ideas ?

Show
Olivier Lamy added a comment - 31/Aug/10 7:11 AM So I have made changes locally. I have the issue : Caused by: org.sonatype.aether.transfer.ArtifactNotFoundException: Could not find artifact org.codehaus.sonar.runtime:sonar-core-maven3-plugin:jar:20100720181619 And I don't know where to find this plugin ? Any Ideas ?
Hide
Permalink
Simon Brandhof added a comment - 31/Aug/10 7:42 AM

Strange. Are you sure that your branch is up-to-date ?

Show
Simon Brandhof added a comment - 31/Aug/10 7:42 AM Strange. Are you sure that your branch is up-to-date ?
Hide
Permalink
Olivier Lamy added a comment - 31/Aug/10 8:16 AM

oups

Show
Olivier Lamy added a comment - 31/Aug/10 8:16 AM oups
Hide
Permalink
Olivier Lamy added a comment - 31/Aug/10 8:40 AM

rev 12463
SNAPSHOT deployed.

Show
Olivier Lamy added a comment - 31/Aug/10 8:40 AM rev 12463 SNAPSHOT deployed.
Hide
Permalink
Anders Hammar added a comment - 31/Aug/10 9:18 AM

When the voting for Maven 3.0-beta-3 passes, would it be possible to get a release of this plugin (with support for 3.0-beta-3)?

Show
Anders Hammar added a comment - 31/Aug/10 9:18 AM When the voting for Maven 3.0-beta-3 passes, would it be possible to get a release of this plugin (with support for 3.0-beta-3)?
Hide
Permalink
Olivier Lamy added a comment - 31/Aug/10 9:29 AM

currently call to findbugs failed

[ERROR] Failed to execute goal org.codehaus.mojo:findbugs-maven-plugin:2.3.1:findbugs (default-cli) on project commontrunk-api: An error has occurred in FindBugs Report report generation. Could not find matching constructor for: org.codehaus.mojo.findbugs.FindbugsReportGenerator(org.codehaus.doxia.module.xhtml.XhtmlSink, java.util.PropertyResourceBundle, java.io.File, org.apache.maven.doxia.tools.DefaultSiteTool) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:findbugs-maven-plugin:2.3.1:findbugs (default-cli) on project commontrunk-api: An error has occurred in FindBugs Report report generation.
Show
Olivier Lamy added a comment - 31/Aug/10 9:29 AM currently call to findbugs failed [ERROR] Failed to execute goal org.codehaus.mojo:findbugs-maven-plugin:2.3.1:findbugs ( default -cli) on project commontrunk-api: An error has occurred in FindBugs Report report generation. Could not find matching constructor for : org.codehaus.mojo.findbugs.FindbugsReportGenerator(org.codehaus.doxia.module.xhtml.XhtmlSink, java.util.PropertyResourceBundle, java.io.File, org.apache.maven.doxia.tools.DefaultSiteTool) -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:findbugs-maven-plugin:2.3.1:findbugs ( default -cli) on project commontrunk-api: An error has occurred in FindBugs Report report generation.
Hide
Permalink
Simon Brandhof added a comment - 31/Aug/10 9:51 AM

Indeed the code to execute maven3 plugins must also be replicated in sonar core. It's used by plugins like Findbugs. Anders, for the same reason, releasing the mojo is not enough. It will require a new release of sonar too.

Show
Simon Brandhof added a comment - 31/Aug/10 9:51 AM Indeed the code to execute maven3 plugins must also be replicated in sonar core. It's used by plugins like Findbugs. Anders, for the same reason, releasing the mojo is not enough. It will require a new release of sonar too.
Hide
Permalink
Olivier Lamy added a comment - 31/Aug/10 9:58 AM

uhm in fact I'm not sure findbug plugin works with maven 3.

Show
Olivier Lamy added a comment - 31/Aug/10 9:58 AM uhm in fact I'm not sure findbug plugin works with maven 3.
Simon Brandhof made changes - 07/Sep/10 5:59 AM
Assignee Simon Brandhof [ simon.brandhof ]
Evgeny Mandrikov made changes - 07/Sep/10 10:19 AM
Assignee Evgeny Mandrikov [ godin ]
Hide
Permalink
Evgeny Mandrikov added a comment - 07/Sep/10 5:20 PM

I confirm that sonar-mojo works fine with 3.0-beta-3, when findbugs-maven-plugin not used.

Show
Evgeny Mandrikov added a comment - 07/Sep/10 5:20 PM I confirm that sonar-mojo works fine with 3.0-beta-3, when findbugs-maven-plugin not used.
Hide
Permalink
Olivier Lamy added a comment - 07/Sep/10 5:23 PM

I have started a branch http://svn.codehaus.org/mojo/branches/findbugs-maven-plugin-MFINDBUGS-119/
so you can try with this (btw some it failed so skip tests for installation )

Show
Olivier Lamy added a comment - 07/Sep/10 5:23 PM I have started a branch http://svn.codehaus.org/mojo/branches/findbugs-maven-plugin-MFINDBUGS-119/ so you can try with this (btw some it failed so skip tests for installation )
Hide
Permalink
Evgeny Mandrikov added a comment - 07/Sep/10 5:26 PM

Cool! Thank you - I'll try it asap.

Show
Evgeny Mandrikov added a comment - 07/Sep/10 5:26 PM Cool! Thank you - I'll try it asap.
Hide
Permalink
benjamin salles added a comment - 08/Sep/10 2:47 AM

I succesfull test it with maven 2.2.1 and sonar 2.2

Show
benjamin salles added a comment - 08/Sep/10 2:47 AM I succesfull test it with maven 2.2.1 and sonar 2.2
Evgeny Mandrikov made changes - 09/Sep/10 6:35 AM
Link This issue relates to SONAR-1772 [ SONAR-1772 ]
Hide
Permalink
Evgeny Mandrikov added a comment - 09/Sep/10 6:54 AM

Hi guys,

This branch doesn't work for me :

 
[INFO] --- findbugs-maven-plugin:2.3.2-SNAPSHOT:findbugs (default-cli) @ sonar-ldap-plugin ---
[INFO] Temp File is /home/godin/projects/sonar-plugins/ldap/target/findbugsTemp.xml
[INFO] Fork Value is true
     [java] Couldn't open /home/godin/projects/sonar-plugins/ldap/target/findbugsTemp.xml for output: java.io.FileNotFoundException: /home/godin/projects/sonar-plugins/ldap/target/findbugsTemp.xml (Is a directory)
     [java] Java Result: 1
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13.341s
[INFO] Finished at: Thu Sep 09 15:52:16 MSD 2010
[INFO] Final Memory: 18M/108M

And also FYI : we are going to remove usage of findbugs-maven-plugin in Sonar (SONAR-1772).

Show
Evgeny Mandrikov added a comment - 09/Sep/10 6:54 AM Hi guys, This branch doesn't work for me : [INFO] --- findbugs-maven-plugin:2.3.2-SNAPSHOT:findbugs (default-cli) @ sonar-ldap-plugin --- [INFO] Temp File is /home/godin/projects/sonar-plugins/ldap/target/findbugsTemp.xml [INFO] Fork Value is true [java] Couldn't open /home/godin/projects/sonar-plugins/ldap/target/findbugsTemp.xml for output: java.io.FileNotFoundException: /home/godin/projects/sonar-plugins/ldap/target/findbugsTemp.xml (Is a directory) [java] Java Result: 1 [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 13.341s [INFO] Finished at: Thu Sep 09 15:52:16 MSD 2010 [INFO] Final Memory: 18M/108M And also FYI : we are going to remove usage of findbugs-maven-plugin in Sonar ( SONAR-1772 ).
Hide
Permalink
Evgeny Mandrikov added a comment - 09/Sep/10 11:34 AM

So I've made fix for branch of findbugs-maven-plugin and now Sonar Mojo works fine with Maven 3.0-beta-3 and Sonar 2.3-SNAPSHOT.

Show
Evgeny Mandrikov added a comment - 09/Sep/10 11:34 AM So I've made fix for branch of findbugs-maven-plugin and now Sonar Mojo works fine with Maven 3.0-beta-3 and Sonar 2.3-SNAPSHOT.
Evgeny Mandrikov made changes - 09/Sep/10 11:35 AM
Link This issue depends upon MFINDBUGS-119 [ MFINDBUGS-119 ]
Freddy Mallet made changes - 30/Sep/10 5:34 PM
Link This issue is related to SONAR-1265 [ SONAR-1265 ]
Simon Brandhof made changes - 12/Oct/10 6:28 AM
Link This issue is depended upon by SONAR-1851 [ SONAR-1851 ]
Evgeny Mandrikov made changes - 21/Oct/10 6:01 PM
Link This issue depends upon MFINDBUGS-119 [ MFINDBUGS-119 ]
Simon Brandhof made changes - 02/Nov/10 12:36 PM
Link This issue is depended upon by SONAR-1851 [ SONAR-1851 ]
Simon Brandhof made changes - 02/Nov/10 12:36 PM
Link This issue depends upon SONAR-1851 [ SONAR-1851 ]
Simon Brandhof made changes - 11/Nov/10 5:18 AM
Assignee Evgeny Mandrikov [ godin ] Simon Brandhof [ simon.brandhof ]
Hide
Permalink
Simon Brandhof added a comment - 11/Nov/10 5:19 AM

Fixed in sonar-maven-plugin 2.0-beta-1.

Show
Simon Brandhof added a comment - 11/Nov/10 5:19 AM Fixed in sonar-maven-plugin 2.0-beta-1.
Simon Brandhof made changes - 11/Nov/10 5:19 AM
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Simon Brandhof made changes - 16/Nov/10 8:08 AM
Fix Version/s sonar-2.0-beta-1 [ 16928 ]
Stephen Connolly made changes - 01/Nov/11 6:02 AM
Project Mojo [ 11062 ] Mojo's Sonar Maven Plugin [ 12430 ]
Key MOJO-1545 MSONAR-10
Component/s sonar [ 14481 ]
Fix Version/s sonar-2.0-beta-1 [ 16928 ]
Complexity Intermediate

People

  • Assignee:
    Simon Brandhof
    Reporter:
    Simon Brandhof
Vote (11)
Watch (19)

Dates

  • Created:
    20/Jul/10 5:39 PM
    Updated:
    01/Nov/11 6:02 AM
    Resolved:
    11/Nov/10 5:19 AM
  • Atlassian JIRA (v5.2.7#850-sha1:b2af0c8)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.