Maven Skins

make Fluido Skin more responsive

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: fluido-1.2.1
  • Fix Version/s: None
  • Component/s: Fluido Skin
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

The maven fluido skin is not optimise for cellphone device.

Patch provided as a proposition but maybe need more css tuning.
The patch provide an upgraded version of bootstrap with .hidden_phone
class which work on <li> tag.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Simone Tripodi added a comment -

while the patch on template is cool, it involves modifications on the CSS that would make hard to maintain fluido up-to-date with future bootstrap evolutions.

Can you please provide a new patch without modifying the CSS? TIA!!!

Show
Simone Tripodi added a comment - while the patch on template is cool, it involves modifications on the CSS that would make hard to maintain fluido up-to-date with future bootstrap evolutions. Can you please provide a new patch without modifying the CSS? TIA!!!
Hide
Permalink
Hugues Obolonsky added a comment - - edited

Modification on CSS came from the 2.0.3-wip branch of twitter bootstrap.
https://github.com/twitter/bootstrap/blob/2.0.3-wip/docs/assets/css/bootstrap-responsive.css

It will be the future bootstrap evolution, i guess

Show
Hugues Obolonsky added a comment - - edited Modification on CSS came from the 2.0.3-wip branch of twitter bootstrap. https://github.com/twitter/bootstrap/blob/2.0.3-wip/docs/assets/css/bootstrap-responsive.css It will be the future bootstrap evolution, i guess
Hide
Permalink
Dennis Lundberg added a comment -

Do you know if this got incorporated into bootstrap 2.0.4?
See MSKINS-54.

Show
Dennis Lundberg added a comment - Do you know if this got incorporated into bootstrap 2.0.4? See MSKINS-54 .
Hide
Permalink
Hugues Obolonsky added a comment -

Since there fluido evolve and remove all refs to a bootstrap reponsive css.
I will make a pull request with updated info on github:apache/maven-skins

Show
Hugues Obolonsky added a comment - Since there fluido evolve and remove all refs to a bootstrap reponsive css. I will make a pull request with updated info on github:apache/maven-skins
Hide
Permalink
Emmanuel Venisse added a comment -

The pull request: https://github.com/apache/maven-skins/pull/1

Show
Emmanuel Venisse added a comment - The pull request: https://github.com/apache/maven-skins/pull/1
Hide
Permalink
Hugues Obolonsky added a comment -

hello Emmanuel,
the site.vm patch is here as a proposition to hide non sensible information when using a phone / tablet.
maybe not the right implementation but provided as idea...
eg: preserve link to the main project, but hide other reference to Apache Fondation Project.

Show
Hugues Obolonsky added a comment - hello Emmanuel, the site.vm patch is here as a proposition to hide non sensible information when using a phone / tablet. maybe not the right implementation but provided as idea... eg: preserve link to the main project, but hide other reference to Apache Fondation Project.

People

  • Assignee:
    Unassigned
    Reporter:
    Hugues Obolonsky
Vote (0)
Watch (3)

Dates

  • Created:
    Updated: