Maven Skins
  1. Maven Skins
  2. MSKINS-28

Make it possible to center "powered by" logos in sidebar

    Details

    • Type: Wish Wish
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: fluido-1.1
    • Fix Version/s: fluido-1.2.2
    • Component/s: Fluido Skin
    • Labels:
      None
    • Number of attachments :
      2

      Description

      Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.

      1. maven-theme.patch
        0.5 kB
        Andreas Sewe
      2. mskins-28-it.patch
        7 kB
        Andreas Sewe

        Activity

        Hide
        Simone Tripodi added a comment -

        GREAT, thanks a lot! I'll review the patch ASAP!
        best,
        -Simo

        Show
        Simone Tripodi added a comment - GREAT, thanks a lot! I'll review the patch ASAP! best, -Simo
        Hide
        Andreas Sewe added a comment -

        Added a patch to accompany the integration test. (CSS tested on Firefox 11 only.)

        Show
        Andreas Sewe added a comment - Added a patch to accompany the integration test. (CSS tested on Firefox 11 only.)
        Hide
        Robert Scholte added a comment -

        @Andreas, could you verify if the patch is still required? I've updated the version of bootstrap and I don't see any real difference.

        Show
        Robert Scholte added a comment - @Andreas, could you verify if the patch is still required? I've updated the version of bootstrap and I don't see any real difference.
        Hide
        Andreas Sewe added a comment -

        I just build a 1.3-SNAPSHOT. There are still two problems present, both due to the img.poweredBy being inline rather than block-level content:

        • If the images are small, several may end up next to each other.
        • If an image is larger than the sidebar, however, its edges are cut off.

        You can experiment with this by explicitly setting the logo's width in your site.xml.

        If you move to block-level content, you avoid the first issue as non-floating blocks cannot sit side-by-side and the second issue because the contained block pushes the boundaries of its container (the sidebar).

        Show
        Andreas Sewe added a comment - I just build a 1.3-SNAPSHOT. There are still two problems present, both due to the img.poweredBy being inline rather than block-level content: If the images are small, several may end up next to each other. If an image is larger than the sidebar, however, its edges are cut off. You can experiment with this by explicitly setting the logo 's width in your site.xml . If you move to block-level content, you avoid the first issue as non-floating blocks cannot sit side-by-side and the second issue because the contained block pushes the boundaries of its container (the sidebar).
        Hide
        Robert Scholte added a comment - - edited

        Fixed in r1356876
        I don't see the issue with the large logo's.
        I can imagine that logo's next to eachother might look odd, it just depends on the sizes. But having them under eachother seems like a safe solution.

        Thanks for the patch!

        Show
        Robert Scholte added a comment - - edited Fixed in r1356876 I don't see the issue with the large logo's. I can imagine that logo's next to eachother might look odd, it just depends on the sizes. But having them under eachother seems like a safe solution. Thanks for the patch!

          People

          • Assignee:
            Robert Scholte
            Reporter:
            Andreas Sewe
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: