Ability to create an ear/war/zip from site

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0-beta-5
  • Fix Version/s: 2.0-beta-6
  • Component/s: None
  • Labels:
    None
  • Patch Submitted:
    Yes

Description

I think they should be standalone goals, like in m1

site:ear -> create ear
site:war -> create war
site:zip -> create zip

I think this one might be a lower priority. I will postpone it.

  1. Text File
    MSITE-45-maven-site-plugin.patch
    21/Aug/06 9:29 AM
    4 kB
    Matthew Beermann
  2. Text File
    patch.txt
    18/Aug/06 1:04 PM
    3 kB
    Matthew Beermann

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MSITE-46 site should behave like an attached artifact

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Allan Ramirez added a comment -

Does the user has the option to choose what package would they like to create? Or all would be created at execute of site:site?

Show
Allan Ramirez added a comment - Does the user has the option to choose what package would they like to create? Or all would be created at execute of site:site?
Hide
Permalink
Matthew Beermann added a comment -

This patch creates a new goal, site:jar, which behaves very much like javadoc:jar - packages everything up and creates an attached artifact. Note that you'll need to add plexus-archiver to the POM.

Show
Matthew Beermann added a comment - This patch creates a new goal, site:jar, which behaves very much like javadoc:jar - packages everything up and creates an attached artifact. Note that you'll need to add plexus-archiver to the POM.
Hide
Permalink
Vincent Siveton added a comment -

Thanks Matthew!

Here my comments:

  • adding a new dependency as plexus-archiver should be include in the patch
  • calling mvn clean site:jar seems to not work. Should be better that SiteJarMojo extends SiteMojo instead of AbstractSiteMojo and using super.execute() if outputDirectory doesnt exist.
  • please read [1] for the Maven's codestyle and how to create patch

[1] http://maven.apache.org/guides/development/guide-m2-development.html

Show
Vincent Siveton added a comment - Thanks Matthew! Here my comments:
  • adding a new dependency as plexus-archiver should be include in the patch
  • calling mvn clean site:jar seems to not work. Should be better that SiteJarMojo extends SiteMojo instead of AbstractSiteMojo and using super.execute() if outputDirectory doesnt exist.
  • please read [1] for the Maven's codestyle and how to create patch
[1] http://maven.apache.org/guides/development/guide-m2-development.html
Hide
Permalink
Matthew Beermann added a comment -

Updated to address review comments.

Show
Matthew Beermann added a comment - Updated to address review comments.
Hide
Permalink
Dennis Lundberg added a comment -

I have applied Matthew's patch, with minor adjustments. The only notable change I made was to change the artifactType from "site" to "jar" in the call to projectHelper.attachArtifact(...). Otherwise the installed attached site would get a .site file ending.

Show
Dennis Lundberg added a comment - I have applied Matthew's patch, with minor adjustments. The only notable change I made was to change the artifactType from "site" to "jar" in the call to projectHelper.attachArtifact(...). Otherwise the installed attached site would get a .site file ending.
Hide
Permalink
Dennis Lundberg added a comment -

I have deployed a new 2.0-beta-6-SNAPSHOT that includes this new jar-mojo. Please give it a try and post your thoughts here. Just run 'mvn site:jar' to try it.

Is this enough or do you feel that the other archive types should be supported as well?

Show
Dennis Lundberg added a comment - I have deployed a new 2.0-beta-6-SNAPSHOT that includes this new jar-mojo. Please give it a try and post your thoughts here. Just run 'mvn site:jar' to try it. Is this enough or do you feel that the other archive types should be supported as well?

People

  • Assignee:
    Dennis Lundberg
    Reporter:
    Brett Porter
Vote (17)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: