Maven Site Plugin
  1. Maven Site Plugin
  2. MSITE-41

Add a list of available language in site plugin

    Details

    • Type: New Feature New Feature
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: internationalization
    • Labels:
      None
    • Number of attachments :
      6

      Description

      Please see the attached screenshots

      This preference menu could be a list of links or a <select/> tag.
      The site descriptor needs to be updated:

      • for <select/>, by adding asSelect attribute in the menu element.
      • for links list, by adding nostrong attribute in the menu element (to not display as strong the current language and the current page)
      1. language_menu.jpg
        76 kB
        Vincent Siveton
      2. language_menu.jpg
        91 kB
        Vincent Siveton
      3. MSITE-41-doxia-sitetools.patch
        17 kB
        Yevgeny Nyden
      4. MSITE-41-maven-site-plugin.patch
        0.5 kB
        Yevgeny Nyden
      1. language_menu_as_select.jpg
        94 kB
      2. language_menu.jpg
        103 kB

        Issue Links

          Activity

          Hide
          Vincent Siveton added a comment -

          Under the "Project Documentation" and before the built by logo.

          Show
          Vincent Siveton added a comment - Under the "Project Documentation" and before the built by logo.
          Hide
          Yevgeny Nyden added a comment -

          OK, I'll try to make 3 placement options available:

          1) breadcrumbs right (current);
          2) breadcrumbs left;
          3) right before the BUILD logo.

          The default will be (1).

          Show
          Yevgeny Nyden added a comment - OK, I'll try to make 3 placement options available: 1) breadcrumbs right (current); 2) breadcrumbs left; 3) right before the BUILD logo. The default will be (1).
          Hide
          Yevgeny Nyden added a comment -

          I added all available position options: left, right, navigation-top, navigation-bottom, bottom, so that the same positioning is avalable for i18nBanner, version, and release date.

          UI test is available here: http://sandbox.curre.net/mvn-site/0 (replace 0 with 1, 2... 5 to see other layout versions). Tested it on FF, Chrome, Safari, and IE7, 8. Is there an official statement on supported browsers? Btw, I wouldn't care about IE6 at this point.

          Note to self (and just so you know):
          I indent to do more work on this:

          1) internationalize the title string on the i18nBannerLink;
          2) add an image to i18nBannerLink;
          3) refactor the publishDate template (it's a mess right now), which will probably remove all IE7 hacks I added;
          4) make sure skins support the new i18nBanner;
          5) write site documentation/example on how to configure i18n;
          6) add unit tests to test the new feature.

          Anything else I missed?

          Is there somebody who can help me with some of these (e.g. documentation)?

          Show
          Yevgeny Nyden added a comment - I added all available position options: left, right, navigation-top, navigation-bottom, bottom, so that the same positioning is avalable for i18nBanner, version, and release date. UI test is available here: http://sandbox.curre.net/mvn-site/0 (replace 0 with 1, 2... 5 to see other layout versions). Tested it on FF, Chrome, Safari, and IE7, 8. Is there an official statement on supported browsers? Btw, I wouldn't care about IE6 at this point. Note to self (and just so you know): I indent to do more work on this: 1) internationalize the title string on the i18nBannerLink; 2) add an image to i18nBannerLink; 3) refactor the publishDate template (it's a mess right now), which will probably remove all IE7 hacks I added; 4) make sure skins support the new i18nBanner; 5) write site documentation/example on how to configure i18n; 6) add unit tests to test the new feature. Anything else I missed? Is there somebody who can help me with some of these (e.g. documentation)?
          Hide
          Vincent Siveton added a comment -

          http://sandbox.curre.net/mvn-site/2 or http://sandbox.curre.net/mvn-site/4/ could be the default IMHO.

          I will review it and commit soon.

          Show
          Vincent Siveton added a comment - http://sandbox.curre.net/mvn-site/2 or http://sandbox.curre.net/mvn-site/4/ could be the default IMHO. I will review it and commit soon.
          Hide
          Lukas Theussl added a comment -

          This will have to be revisited after MSITE-322. Different language sites are now deployed into their own tree like eg

          main
           index.html
           submodule/index.html
          
           fr/index.html
           fr/submodule/index.html
          

          Before it was:

          main
           index.html
           fr/index.html
          
           submodule/index.html
           submodule/fr/index.html
          

          so switching between language sites, the relative links have changed.

          Show
          Lukas Theussl added a comment - This will have to be revisited after MSITE-322 . Different language sites are now deployed into their own tree like eg main index.html submodule/index.html fr/index.html fr/submodule/index.html Before it was: main index.html fr/index.html submodule/index.html submodule/fr/index.html so switching between language sites, the relative links have changed.

            People

            • Assignee:
              Unassigned
              Reporter:
              Vincent Siveton
            • Votes:
              6 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated: