site:stage creates wrong links on Linux

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.1
  • Component/s: relative links, site descriptor
  • Labels:
    None
  • Environment:
    Linux

Description

site:stage creates wrong links in the navigation menu, something is messed up with the relative-path resolution. The same links created with site:site are correct.

Note that this has nothing to do with multi-module setups (as reported before: MSITE-275, MSITE-395), it happens on a simple project.

Also it seems to be Unix specific as vsiveton told me it works on Windows.

Issue Links

depends upon

Bug - A problem which impairs or prevents the functions of the product. DOXIASITETOOLS-29 PathUtils.getRelativePath returns different results on Windows and Linux

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Task - A task that needs to be done. MSITE-419 Update to Doxia 1.1.2

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MSITE-395 Maven site multi module url problem

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
supercedes

Bug - A problem which impairs or prevents the functions of the product. MSITE-391 site:state creates wrong links for menu items

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Lukas Theussl added a comment -

Trivial test project. site:site creates correct links (eg 

<a href="test.html">MSITE-404</a>
for test.html) but site:stage gives 
<a href="../home/lukas/maven/jira/m2/site/MSITE-404/msite-404/../msite-404">MSITE-404</a>
for the same.

Show
Lukas Theussl added a comment - Trivial test project. site:site creates correct links (eg 
<a href="test.html">MSITE-404</a>
for test.html) but site:stage gives 
<a href="../home/lukas/maven/jira/m2/site/MSITE-404/msite-404/../msite-404">MSITE-404</a>
for the same.
Hide
Permalink
Dennis Lundberg added a comment -

Confirmed on Ubuntu 7.10.

Show
Dennis Lundberg added a comment - Confirmed on Ubuntu 7.10.
Hide
Permalink
Dennis Lundberg added a comment - - edited

I've traced this down to DefaultDecorationModelInheritanceAssembler#resolvePaths( final DecorationModel decoration, final String baseUrl ) in doxia-decoration-model. But then I'm stuck. Two things happen in that method:

  1. The href part of a menuitem that is in the site.xml file is lost (might be other elements containing paths as well)
  2. The path is resolved into something that is just plain weird: 
    ../<absolutePathToProject>/../<artifactId>
Show
Dennis Lundberg added a comment - - edited I've traced this down to DefaultDecorationModelInheritanceAssembler#resolvePaths( final DecorationModel decoration, final String baseUrl ) in doxia-decoration-model. But then I'm stuck. Two things happen in that method:
  1. The href part of a menuitem that is in the site.xml file is lost (might be other elements containing paths as well)
  2. The path is resolved into something that is just plain weird: 
    ../<absolutePathToProject>/../<artifactId>
Hide
Permalink
Lukas Theussl added a comment -

I am currently also stuck with hunting this down. However, some remark: the only difference between site:site and site:stage is that site:stage sets the project url to a relative path ('../msite-404' in my test case). This sounds weird to me as first, it's supposed to be the distMangmt's url that is used by site:stage, and second, it's not a valid url.

If you're curious, just add <url>../msite-404</url> to my test pom, then site:site will give you the same (bad) links as site:stage. I would never suppose this to be correct for site:site, so why should it be for site:stage?

Show
Lukas Theussl added a comment - I am currently also stuck with hunting this down. However, some remark: the only difference between site:site and site:stage is that site:stage sets the project url to a relative path ('../msite-404' in my test case). This sounds weird to me as first, it's supposed to be the distMangmt's url that is used by site:stage, and second, it's not a valid url. If you're curious, just add <url>../msite-404</url> to my test pom, then site:site will give you the same (bad) links as site:stage. I would never suppose this to be correct for site:site, so why should it be for site:stage?
Hide
Permalink
Lukas Theussl added a comment -

The reason for the different results on Windows/Linux is due to PLXUTILS-116. However, we need to check if this method is used correctly in DecorationModel, we can probably work around it.

Show
Lukas Theussl added a comment - The reason for the different results on Windows/Linux is due to PLXUTILS-116. However, we need to check if this method is used correctly in DecorationModel, we can probably work around it.
Hide
Permalink
Lukas Theussl added a comment - - edited

Trunk has been bumped to doxia-1.1.2-SNAPSHOT ( r798235), snapshot is deployed for testing.

Show
Lukas Theussl added a comment - - edited Trunk has been bumped to doxia-1.1.2-SNAPSHOT ( r798235), snapshot is deployed for testing.

People

  • Assignee:
    Lukas Theussl
    Reporter:
    Lukas Theussl
Vote (4)
Watch (6)

Dates

  • Created:
    Updated:
    Resolved: