Maven 2.x and 3.x Site Plugin

remove copy of reporting-api SinkFactory class

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0-beta-7
  • Fix Version/s: 2.1
  • Component/s: doxia integration
  • Labels:
    None
  • Number of attachments :
    0

Description

this will force the plugin to have Maven 2.0.8 as a prerequisite, since this interface was added in doxia-sink-api 1.0-alpha-9, in use in Maven 2.0.8

Issue Links

is related to

Task - A task that needs to be done. MSITE-369 remove copy of reporting-api MavenMultiPageReport class

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dennis Lundberg added a comment -

Is it only the class org.apache.maven.doxia.sink.SinkFactory that should be removed?

Show
Dennis Lundberg added a comment - Is it only the class org.apache.maven.doxia.sink.SinkFactory that should be removed?
Hide
Permalink
Herve Boutemy added a comment -

I wrote "sorting out Maven dependencies on Doxia" section in Doxia Release Plan to track precisely the logic I found when reading code history.

then AFAIK, this is the only class that should be removed from maven-site-plugin 2.1. MSITE-369 is here for another class in version 3.0.
This analysis should probably be reviewed by every Doxia developers since it's not so easy: the more eyes (and brains) the better.

Show
Herve Boutemy added a comment - I wrote "sorting out Maven dependencies on Doxia" section in Doxia Release Plan to track precisely the logic I found when reading code history. then AFAIK, this is the only class that should be removed from maven-site-plugin 2.1. MSITE-369 is here for another class in version 3.0. This analysis should probably be reviewed by every Doxia developers since it's not so easy: the more eyes (and brains) the better.
Hide
Permalink
Lukas Theussl added a comment -

The only possible problem I see is that the SinkFactory in Doxia 1.1 is not identical anymore to the SinkFactory in Doxia 1.0 (which the site plugin has copied), some signatures where added for 1.1. However, the site plugin now has a prereq on maven 2.1 (using doxia-1.1), so I think at least binary compatibility should be ok. I'd remove the class already and see what happens on the grid...

Show
Lukas Theussl added a comment - The only possible problem I see is that the SinkFactory in Doxia 1.1 is not identical anymore to the SinkFactory in Doxia 1.0 (which the site plugin has copied), some signatures where added for 1.1. However, the site plugin now has a prereq on maven 2.1 (using doxia-1.1), so I think at least binary compatibility should be ok. I'd remove the class already and see what happens on the grid...
Hide
Permalink
Lukas Theussl added a comment -

Done in r890870. Grid seems happy...

Show
Lukas Theussl added a comment - Done in r890870 . Grid seems happy...

People

  • Assignee:
    Lukas Theussl
    Reporter:
    Herve Boutemy
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: