Maven 2.x and 3.x Site Plugin

site:stage-deploy creates different directory structure than site:site

Details

  • Number of attachments :
    0

Description

Given a parent and a child module, the regular site directory structure is

   <site-root>/
      child/

which is expected by all the inter-module links.

In contrast, site:stage-deploy will create

  <site-root>/
    staging/
    child/
      staging/

instead of 

  <site-root>/
    staging/
      child/

This is due to the configuration of the mojo paramter stagingSiteURL which is constructed by the site URL of the current project and appending a subdir like "staging". This is only usuable for the parent project, for child modules the subdir "staging" needs to be inserted before the subdir for the child module is appended.

Issue Links

This issue is related to:
MSITE-275 site:stage for multimodule project creates wrong links Major Closed
MSITE-537 site:stage-deploy creates wrong directory structure if run from a sub-module Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Bentmann added a comment -

Forgot to mention: This altered directory structure will cause the inter-module links to fail.

A demo project can be taken from MSITE-180 as provided by Gabriel Falkenberg.

Show
Benjamin Bentmann added a comment - Forgot to mention: This altered directory structure will cause the inter-module links to fail. A demo project can be taken from MSITE-180 as provided by Gabriel Falkenberg.
Hide
Permalink
Dennis Lundberg added a comment -

Fixed in r666352.
New 2.0-beta-7-SNAPSHOT deployed.
Please verify.

Show
Dennis Lundberg added a comment - Fixed in r666352. New 2.0-beta-7-SNAPSHOT deployed. Please verify.
Hide
Permalink
Benjamin Bentmann added a comment -

Looks generally good, the inter-module links in the navibar on the left are functional.

However there is still a discrepancy between the staging goals and a regular site deploy. E.g. compared against a site-deploy to localhost, I observe the following differences to the staged site:

index.html of sub-module, correctly points to parent
<a href="../" id="bannerRight">
<img src="../images/logo.png" alt="foo" />
index.html of staged sub-module, incorrectly points to somewhere
<a href="..\..\..\..\..\..\..\..\..\..\..\sub-module" id="bannerRight">
<img src="../../sub-module" alt="foo" />

Also note that the href is using backslashes which is invalid for URLs. I will try to fill in a new issue with some test project shortly.

Show
Benjamin Bentmann added a comment - Looks generally good, the inter-module links in the navibar on the left are functional. However there is still a discrepancy between the staging goals and a regular site deploy. E.g. compared against a site-deploy to localhost, I observe the following differences to the staged site:
index.html of sub-module, correctly points to parent
<a href="../" id="bannerRight">
<img src="../images/logo.png" alt="foo" />
index.html of staged sub-module, incorrectly points to somewhere
<a href="..\..\..\..\..\..\..\..\..\..\..\sub-module" id="bannerRight">
<img src="../../sub-module" alt="foo" />
Also note that the href is using backslashes which is invalid for URLs. I will try to fill in a new issue with some test project shortly.
Hide
Permalink
Dennis Lundberg added a comment -

Thanks Benjamin,
I'm trying to create an IT for this issue, but I can't get it to work like I want it to my first IT. I'm using the MSITE-265 IT as a template. Will try to make one for MSITE-316 as well.

Show
Dennis Lundberg added a comment - Thanks Benjamin, I'm trying to create an IT for this issue, but I can't get it to work like I want it to my first IT. I'm using the MSITE-265 IT as a template. Will try to make one for MSITE-316 as well.
Hide
Permalink
Benjamin Bentmann added a comment -

The issue with the links seems related to MSITE-275, so I attached the demo project there.

Show
Benjamin Bentmann added a comment - The issue with the links seems related to MSITE-275, so I attached the demo project there.

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.