install must fix the plugin descriptor version before installing the jar

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: 1.0-alpha-1
  • Fix Version/s: 1.0-alpha-4
  • Component/s: Install
  • Labels:
    None

Description

The install goal seems only to be taking the already built jar and installing it with the "testing" version into the repo. The plugins contain metadata that has the version. If this version is not also updated to "testing" then bad things can happen. Specifically the plugin isn't found and default phases aren't used when running tests under 2.1.

We had a similar problem with the plugin-testing-harness that corrupted the default artifact with "test" and thus screwed people up at runtime. More info is here: MECLIPSE-239

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MRPM-80 Integration tests fail using maven 2.2.1

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MSHITTY-33 Maven SHITTY Plugin fails when used with Maven 2.1.0 (Needs to update internal plugin metadata)

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.
is related to

Bug - A problem which impairs or prevents the functions of the product. MNG-3284 Cached plugins are used, even when the specifically declared

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MNG-1323 Plugin extensions (dependencies) not resolved in reactor build

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MOJO-1359 -Pintegration-tests doesn't work on mvn 2.1.0

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jason Dillon added a comment -

This is actually causing gmaven release:prepare builds to fail... so need to sort this out soon.

Show
Jason Dillon added a comment - This is actually causing gmaven release:prepare builds to fail... so need to sort this out soon.
Hide
Permalink
Richard Vowles added a comment -

This patch fixes this problem. It causes the pom.xml to be re-written (if it has a version) and the jar to be extracted and the plugin.xml and pom.xml to be re-written.

The only thing it doesn't watch for is parent-POMs, but they don't seem to matter.

Show
Richard Vowles added a comment - This patch fixes this problem. It causes the pom.xml to be re-written (if it has a version) and the jar to be extracted and the plugin.xml and pom.xml to be re-written. The only thing it doesn't watch for is parent-POMs, but they don't seem to matter.
Hide
Permalink
pkernevez added a comment -

Hi,

We need this fix and I see that there isn't any release for 3 years.
Is any active developers on this plugin ? Or do I do a release myself ?

Show
pkernevez added a comment - Hi, We need this fix and I see that there isn't any release for 3 years. Is any active developers on this plugin ? Or do I do a release myself ?
Hide
Permalink
Wim Deblauwe added a comment -

This also affects the RPM maven plugin, see MRPM-80. I would link them, but I don't have the rights to do so it seems.

Show
Wim Deblauwe added a comment - This also affects the RPM maven plugin, see MRPM-80. I would link them, but I don't have the rights to do so it seems.
Hide
Permalink
Brett Okken added a comment -

I created the link to MRPM-80.

pkernevez, it would be great if you could do a release.

Show
Brett Okken added a comment - I created the link to MRPM-80. pkernevez, it would be great if you could do a release.
Hide
Permalink
kristian meier added a comment -

I also would appreciate a release fixing the bug. I have a workaround in place using the same version as the artifact which get tested (can be configured for shitty:install) instead of using the version 'testing'. but I have to update this version manually since the release plugin does not do this and there are quite some places to udpate.

Show
kristian meier added a comment - I also would appreciate a release fixing the bug. I have a workaround in place using the same version as the artifact which get tested (can be configured for shitty:install) instead of using the version 'testing'. but I have to update this version manually since the release plugin does not do this and there are quite some places to udpate.

People

  • Assignee:
    Jason Dillon
    Reporter:
    Brian Fox
Vote (7)
Watch (9)

Dates

  • Created:
    Updated: