Maven Shared Components

Maven2OsgiConverter unnecessarily pads version numbers

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: maven-osgi
  • Labels:
    None
  • Number of attachments :
    2

Description

In DefaultMavenOsgiConverter#getVersion(), there's logic to the effect of:

/* convert

  • 1.string -> 1.0.0.string
  • 1.2.string -> 1.2.0.string
  • 1 -> 1.0.0
  • 1.1 -> 1.1.0
    */

...which is unnecessary; the version number only needs to be padded out to three places when there's a qualifier present.

  1. Text File
    MSHARED-98-maven-osgi.patch
    14/Apr/09 3:15 PM
    4 kB
    Matthew Beermann
  2. Text File
    MSHARED-98-maven-osgi.patch
    14/Apr/09 2:46 PM
    3 kB
    Matthew Beermann

Activity

Ascending order - Click to sort in descending order
Matthew Beermann made changes -
Field Original Value New Value
Attachment MSHARED-98-maven-osgi.patch [ 41344 ]
Matthew Beermann made changes -
Attachment MSHARED-98-maven-osgi.patch [ 41348 ]
Hide
Permalink
luke w patterson added a comment -

saw something that might be related, throwing this out there so there's a trail:
"Fix inconsistent maven->osgi version conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter"
https://issues.apache.org/jira/browse/FELIX-2173

Show
luke w patterson added a comment - saw something that might be related, throwing this out there so there's a trail: "Fix inconsistent maven->osgi version conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter" https://issues.apache.org/jira/browse/FELIX-2173
Hide
Permalink
Guillaume Nodet added a comment -

What I've fixed as part of FELIX-2173 is slightly different.
The problem was that the osgi conversion used to convert '-' to '_' in the qualifier without any real need for that.
The patch I used is available at
http://svn.apache.org/viewvc/felix/trunk/bundleplugin/src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java?p2=/felix/trunk/bundleplugin/src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java&p1=/felix/trunk/bundleplugin/src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java&r1=919426&r2=919425&view=diff&pathrev=919426

I used the BND mechanism modified to honor the padding as it was the case previously.
Removing the padding should be as simple as deleting three lines in the above patch.

Show
Guillaume Nodet added a comment - What I've fixed as part of FELIX-2173 is slightly different. The problem was that the osgi conversion used to convert '-' to '_' in the qualifier without any real need for that. The patch I used is available at http://svn.apache.org/viewvc/felix/trunk/bundleplugin/src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java?p2=/felix/trunk/bundleplugin/src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java&p1=/felix/trunk/bundleplugin/src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java&r1=919426&r2=919425&view=diff&pathrev=919426 I used the BND mechanism modified to honor the padding as it was the case previously. Removing the padding should be as simple as deleting three lines in the above patch.

People

  • Assignee:
    Unassigned
    Reporter:
    Matthew Beermann
Vote (2)
Watch (3)

Dates

  • Created:
    Updated: