Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: maven-common-artifact-filters
-
Labels:None
-
Number of attachments :
Description
There is a todo in http://svn.apache.org/viewvc/maven/components/trunk/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/filter/IncludesArtifactFilter.java?view=markup to add regex. I checked all the sources and could only find usages of this code by maven-assembly-plugin, webstart-maven-plugin and exec-maven-plugin. The latter two are in mojo.
If you look at http://svn.palle.net/projects/hauskeeper/hauskeeper-server/src/assemblies/debian.xml, Trygvis is assuming that wildcards work, when in fact they do not. Arguably, this is a documentation bug that it does not work.
The attached patch fixes this problem.
Issue Links
- relates to
-
MWEBSTART-45
Reuse artifcat filters that understand patterns
-
Activity
Jason van Zyl
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Component/s | Artifacts and Repositories [ 11338 ] | |
| Component/s | Artifacts [ 12035 ] |
Jason van Zyl
made changes -
| Patch Submitted | [Yes] |
Jason van Zyl
made changes -
| Status | Open [ 1 ] | Closed [ 6 ] |
| Resolution | Fixed [ 1 ] |
Brett Porter
made changes -
| Status | Closed [ 6 ] | Reopened [ 4 ] |
| Assignee | Jason van Zyl [ jason ] | |
| Resolution | Fixed [ 1 ] |
Brett Porter
made changes -
| Resolution | Won't Fix [ 2 ] | |
| Status | Reopened [ 4 ] | Closed [ 6 ] |
Mark Hobson
made changes -
| Attachment | MNG-2621.patch [ 27995 ] |
John Casey
made changes -
| Status | Closed [ 6 ] | Reopened [ 4 ] |
| Resolution | Won't Fix [ 2 ] |
John Casey
made changes -
| Component/s | Artifacts and Repositories [ 11338 ] | |
| Component/s | Shared [ 12784 ] | |
| Patch Submitted | [Yes] | |
| Fix Version/s | 2.0.x [ 13141 ] | |
| Description |
There is a todo in http://svn.apache.org/viewvc/maven/components/trunk/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/filter/IncludesArtifactFilter.java?view=markup to add regex. I checked all the sources and could only find usages of this code by maven-assembly-plugin, webstart-maven-plugin and exec-maven-plugin. The latter two are in mojo. If you look at http://svn.palle.net/projects/hauskeeper/hauskeeper-server/src/assemblies/debian.xml, Trygvis is assuming that wildcards work, when in fact they do not. Arguably, this is a documentation bug that it does not work. The attached patch fixes this problem. |
There is a todo in http://svn.apache.org/viewvc/maven/components/trunk/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/filter/IncludesArtifactFilter.java?view=markup to add regex. I checked all the sources and could only find usages of this code by maven-assembly-plugin, webstart-maven-plugin and exec-maven-plugin. The latter two are in mojo. If you look at http://svn.palle.net/projects/hauskeeper/hauskeeper-server/src/assemblies/debian.xml, Trygvis is assuming that wildcards work, when in fact they do not. Arguably, this is a documentation bug that it does not work. The attached patch fixes this problem. |
John Casey
made changes -
| Assignee | Jason van Zyl [ jason ] | John Casey [ jdcasey ] |
Mark Hobson
made changes -
| Assignee | John Casey [ jdcasey ] | Mark Hobson [ mihobson ] |
| Summary | IncludesArtifactFilter in maven-artifact should accept wildcards | Add stricter pattern filters to maven-common-artifact-filters |
Mark Hobson
made changes -
| Fix Version/s | Shared Components [ 13561 ] | |
| Fix Version/s | 2.0.x [ 13141 ] | |
| Status | Reopened [ 4 ] | Closed [ 6 ] |
| Resolution | Fixed [ 1 ] |
Vincent Siveton
made changes -
| Component/s | maven-common-artifact-filters [ 13269 ] | |
| Project | Maven 2 [ 10500 ] | Maven Shared Components [ 11761 ] |
| Fix Version/s | Shared Components [ 13561 ] | |
| Component/s | Shared [ 12784 ] | |
| Key | MNG-2621 |
|
Jerome Lacoste
made changes -
| Link | This issue relates to MWEBSTART-45 [ MWEBSTART-45 ] |