Maven Shared Components

FilteringUtils escapeWindowsPath() doesn't work on Windows

Details

  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

The method escapeWindowsPath() is replacing colon by backslash + colon.
I.e.
D:\temp
is escaped as
D\:
temp

But windows doesn't recognize that. If you try to open D\:
temp on explorer, will not work.
Even java.io.File is not able to handle that too. The attached test proves it.

I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils make the test work.

  1. Text File
    filtering.patch
    17/Feb/09 11:44 AM
    0.9 kB
    Marvin Froeder
  2. Java Source File
    FilteringUtilsTest.java
    29/Oct/08 7:41 AM
    0.8 kB
    Marvin Froeder

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MRESOURCES-81 2.3 escapes characters when filtering properties

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. MRESOURCES-42 Filtering properties that contain ${basedir} for property files doesn't escape backslashes

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MRESOURCES-81 2.3 escapes characters when filtering properties

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MRESOURCES-106 Plugin does not respect escapeWindowsPaths default-value

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Marvin Froeder made changes -
Field Original Value New Value
Affects Version/s 2.3 [ 12622 ]
Marvin Froeder made changes -
Link This issue is related to MRESOURCES-42 [ MRESOURCES-42 ]
Olivier Lamy made changes -
Affects Version/s 2.3 [ 12622 ]
Affects Version/s maven-filtering-1.0-beta-2 [ 14488 ]
Key MRESOURCES-76 MSHARED-78
Project Maven 2.x Resources Plugin [ 11145 ] Maven Shared Components [ 11761 ]
Issue Type Bug [ 1 ] Improvement [ 4 ]
Olivier Lamy made changes -
Fix Version/s maven-filtering-1.0 [ 14631 ]
Component/s maven-filtering [ 13380 ]
Olivier Lamy made changes -
Fix Version/s maven-filtering-1.0-beta-3 [ 14631 ]
Fix Version/s maven-filtering-1.0-beta-4 [ 14861 ]
Olivier Lamy made changes -
Link This issue is related to MRESOURCES-81 [ MRESOURCES-81 ]
Paul Jackson made changes -
Link This issue is depended upon by MRESOURCES-81 [ MRESOURCES-81 ]
Marvin Froeder made changes -
Attachment filtering.patch [ 40081 ]
Olivier Lamy made changes -
Assignee Olivier Lamy [ olamy ]
Olivier Lamy made changes -
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Marvin Froeder made changes -
Link This issue relates to MRESOURCES-106 [ MRESOURCES-106 ]

People

  • Assignee:
    Olivier Lamy
    Reporter:
    Marvin Froeder
Vote (3)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: