Maven Shared Components

Verifier doesn't throw VerificationException upon non-zero exit code of mvn.bat on Windows

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: maven-verifier-1.0
  • Fix Version/s: maven-verifier-1.2
  • Component/s: maven-verifier
  • Labels:
    None
  • Environment:
    Windows XP
  • Number of attachments :
    0

Description

Running the core ITs on a Windows box I got:

Failed tests:
  testitMNG3748(org.apache.maven.integrationtests.MavenITmng3748BadSettingsXmlTest)
  testitMNG3314(org.apache.maven.integrationtests.MavenITmng3314OfflineSnapshotsTest)
  testitMNG3220b(org.apache.maven.integrationtests.MavenITmng3220ImportScopeTest)
  testitMNG2695(org.apache.maven.integrationtests.MavenITmng2695OfflinePluginSnapshotsTest)

Investigation showed these failures were due to the Verifier not detecting the (expected) build failure of the IT. Just like in maven-invoker, the environment variable MAVEN_TERMINATE_CMD needs to be set to quit the entire cmd.exe process and not only mvn.bat.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MSHARED-76 Verifier executeGoal method is OS-dependent in case of failure

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. MINVOKER-3 Invoker always returns 0 on Windows due to cmd.exe and exit /b in mvn.bat

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Hide
Permalink
Benjamin Bentmann added a comment -

Fixed in r696386.

Show
Benjamin Bentmann added a comment - Fixed in r696386 .

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Benjamin Bentmann
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: