Maven Shared Components
  1. Maven Shared Components
  2. MSHARED-31

Move logic inside AbstractProjectInfoReport to maven-reporting-impl

    Details

    • Type: Improvement Improvement
    • Status: Open Open
    • Priority: Blocker Blocker
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: maven-reporting-impl
    • Labels:
      None
    • Number of attachments :
      0

      Description

      Due to doxia:1.0-alpha-9, the following methods need to be a part of maven-reporting-impl:

      private File getSkinArtifactFile();
      public void execute();

      So, it should be more easy to create a new report plugin.

        Activity

        Hide
        Dennis Lundberg added a comment -

        Are you saying that we can't release maven-pir-plugin 2.1 until this is fixed? Otherwise I would like to push this issue to the next release.

        Show
        Dennis Lundberg added a comment - Are you saying that we can't release maven-pir-plugin 2.1 until this is fixed? Otherwise I would like to push this issue to the next release.
        Hide
        Vincent Siveton added a comment -

        The main goal of this issue was how to create a new MavenReport (which extends AbstractMavenReport) with new Doxia dependency. The main pb that I found is how to use the correct sink.
        If you release MPIRP like this, I guess that we need to copy and paste these methods in all reports which will be bumped to Doxia:1.0-alpha-9

        Show
        Vincent Siveton added a comment - The main goal of this issue was how to create a new MavenReport (which extends AbstractMavenReport) with new Doxia dependency. The main pb that I found is how to use the correct sink. If you release MPIRP like this, I guess that we need to copy and paste these methods in all reports which will be bumped to Doxia:1.0-alpha-9
        Hide
        Dennis Lundberg added a comment -

        Do you mean reports within the maven-pir-plugin or other reports?

        This plugin builds and runs fine as it is now, with doxia 1.0-alpha-9. I don't see what the problem is.

        Show
        Dennis Lundberg added a comment - Do you mean reports within the maven-pir-plugin or other reports? This plugin builds and runs fine as it is now, with doxia 1.0-alpha-9. I don't see what the problem is.
        Hide
        Vincent Siveton added a comment -

        The main pb is not in the MPIR (works fine) but in all report pending plugins. We need to extract this logic somewhere to avoid copy/paste.

        Just try to create a new report plugin with doxia:1.0-alpha-9 and specify the following content

                getSink().head();
                getSink().text( "REPORT NAME" );
                getSink().head_();
        
        Show
        Vincent Siveton added a comment - The main pb is not in the MPIR (works fine) but in all report pending plugins. We need to extract this logic somewhere to avoid copy/paste. Just try to create a new report plugin with doxia:1.0-alpha-9 and specify the following content getSink().head(); getSink().text( "REPORT NAME" ); getSink().head_();
        Hide
        Dennis Lundberg added a comment -

        But this has no effect on maven-project-info-reports-plugin. That is an issue for the reporting-api and reporting-implementation. I still don't see why this should hold up the release of MPIR. Other reporting plugins do not extend classes from MPIR. It is only when the reporting-api/reporting-implementation upgrades to doxia-1.0-alpha-9 that this would have any effect on other reporting plugins.

        Show
        Dennis Lundberg added a comment - But this has no effect on maven-project-info-reports-plugin. That is an issue for the reporting-api and reporting-implementation. I still don't see why this should hold up the release of MPIR. Other reporting plugins do not extend classes from MPIR. It is only when the reporting-api/reporting-implementation upgrades to doxia-1.0-alpha-9 that this would have any effect on other reporting plugins.
        Hide
        Vincent Siveton added a comment -

        first step in r614398

        Show
        Vincent Siveton added a comment - first step in r614398
        Hide
        Dennis Lundberg added a comment -

        I think that I understand the problem now. Would you mind having a look over at MCHANGES-88 and see if it is this problem that we're hitting there?

        Show
        Dennis Lundberg added a comment - I think that I understand the problem now. Would you mind having a look over at MCHANGES-88 and see if it is this problem that we're hitting there?

          People

          • Assignee:
            Unassigned
            Reporter:
            Vincent Siveton
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: