Issue Details (XML | Word | Printable)

Key: MSHARED-31
Type: Improvement Improvement
Status: Open Open
Priority: Blocker Blocker
Assignee: Unassigned
Reporter: Vincent Siveton
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Maven Shared Components

Move logic inside AbstractProjectInfoReport to maven-reporting-impl

Created: 03/Nov/07 05:15 AM   Updated: 12/Jun/08 06:51 PM
Component/s: maven-reporting-impl
Affects Version/s: None
Fix Version/s: None

Time Tracking:
Not Specified


 Description  « Hide

Due to doxia:1.0-alpha-9, the following methods need to be a part of maven-reporting-impl:

private File getSkinArtifactFile();
public void execute();

So, it should be more easy to create a new report plugin.



Dennis Lundberg added a comment - 06/Nov/07 04:04 PM

Are you saying that we can't release maven-pir-plugin 2.1 until this is fixed? Otherwise I would like to push this issue to the next release.


Vincent Siveton added a comment - 06/Nov/07 05:40 PM

The main goal of this issue was how to create a new MavenReport (which extends AbstractMavenReport) with new Doxia dependency. The main pb that I found is how to use the correct sink.
If you release MPIRP like this, I guess that we need to copy and paste these methods in all reports which will be bumped to Doxia:1.0-alpha-9


Dennis Lundberg added a comment - 06/Nov/07 05:53 PM

Do you mean reports within the maven-pir-plugin or other reports?

This plugin builds and runs fine as it is now, with doxia 1.0-alpha-9. I don't see what the problem is.


Vincent Siveton added a comment - 06/Nov/07 06:02 PM

The main pb is not in the MPIR (works fine) but in all report pending plugins. We need to extract this logic somewhere to avoid copy/paste.

Just try to create a new report plugin with doxia:1.0-alpha-9 and specify the following content

        getSink().head();
        getSink().text( "REPORT NAME" );
        getSink().head_();

Dennis Lundberg added a comment - 07/Nov/07 04:32 PM

But this has no effect on maven-project-info-reports-plugin. That is an issue for the reporting-api and reporting-implementation. I still don't see why this should hold up the release of MPIR. Other reporting plugins do not extend classes from MPIR. It is only when the reporting-api/reporting-implementation upgrades to doxia-1.0-alpha-9 that this would have any effect on other reporting plugins.


Vincent Siveton added a comment - 22/Jan/08 06:34 PM

first step in r614398


Dennis Lundberg added a comment - 06/Feb/08 04:53 PM

I think that I understand the problem now. Would you mind having a look over at MCHANGES-88 and see if it is this problem that we're hitting there?