Maven Shared Components

stage dies at normalization of relative path

Details

  • Testcase included:
    yes
  • Number of attachments :
    2

Description

Since r640091, DefaultSiteTool from maven-doxia-tools tries to normalize paths, which fails, as the current plexus-utils don't handle normalization of relative paths, and the stage mojo seems to use them quite extensively.

I have attached a small testcase, a parent project with a single child, and site:stage as the default goal, so you can simply run "mvn" on the parent. Debugging this shows that FileUtils.normalize is handed a path starting in "../../".

I have also attached a patch to plexus-utils that makes FileUtils.normalize handle relative paths, but I'm not sure if this would be intended, and I can't test it, because I can't get maven use the latest snapshot of plexus-utils, even if stated as an explicit dependency of the site plugin.

See also:
http://svn.apache.org/viewvc/maven/shared/trunk/maven-doxia-tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java?r1=637431&r2=640091&diff_format=h#l72
http://fisheye.codehaus.org/browse/plexus/plexus-utils/trunk/src/main/java/org/codehaus/plexus/util/FileUtils.java

  1. Text File
    normalizeRelativePaths.patch
    09/Apr/08 12:41 AM
    2 kB
    Martin von Gagern

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MSHARED-15 DefaultSiteTools fails on paths with prefix "../"

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Vincent Siveton made changes -
Field Original Value New Value
Affects Version/s 2.0-beta-7 [ 13092 ]
Project Maven 2.x Site Plugin [ 11146 ] Maven Shared Components [ 11761 ]
Key MSITE-315 MSHARED-16
Vincent Siveton made changes -
Component/s maven-doxia-tools [ 13263 ]
Benjamin Bentmann made changes -
Link This issue is related to MSHARED-15 [ MSHARED-15 ]
Hide
Permalink
Dennis Lundberg added a comment -

I think that this is a duplicate of MSHARED-15, which was fixed and included in maven-doxia-tools 1.0. I'm unable to produce any error from the testcase.

Martin, can you confirm that this is fixed in maven-doxia-tools 1.0?

Show
Dennis Lundberg added a comment - I think that this is a duplicate of MSHARED-15 , which was fixed and included in maven-doxia-tools 1.0. I'm unable to produce any error from the testcase. Martin, can you confirm that this is fixed in maven-doxia-tools 1.0?
Hide
Permalink
Martin von Gagern added a comment -

Verifying with maven-doxia-tools 1.0 I encountered MSHARED-32. With maven-doxia-tools 1.0.1 I got no error. So I confirm this is fixed.

Show
Martin von Gagern added a comment - Verifying with maven-doxia-tools 1.0 I encountered MSHARED-32 . With maven-doxia-tools 1.0.1 I got no error. So I confirm this is fixed.
Dennis Lundberg made changes -
Fix Version/s maven-doxia-tools 1.0 [ 14364 ]
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Martin von Gagern
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: