Maven 2.x Shade Plugin

Build output log is littered with duplicate warnings

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.3.3, 1.4
  • Fix Version/s: None
  • Labels:
    None
  • Number of attachments :
    0

Issue Links

relates to

New Feature - A new feature of the product, which has yet to be developed. MSHADE-91 Allow using external Shader implementation

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Elisha Ezeugoh added a comment -

Opened pull request https://github.com/apache/maven-plugins/pull/1

Show
Elisha Ezeugoh added a comment - Opened pull request https://github.com/apache/maven-plugins/pull/1
Hide
Permalink
Benson Margulies added a comment -

For legal reasons, please make a diff and attach it here. git is just a mirror, we don't apply patches there.

Show
Benson Margulies added a comment - For legal reasons, please make a diff and attach it here. git is just a mirror, we don't apply patches there.
Hide
Permalink
Benson Margulies added a comment -

Why is the cache a field? Doesn't this result in suppressing warnings across invocations of the plugin? And if the component strategy prevents that, why not just create it in the shade method?

We really should have a test case to go with this.

Show
Benson Margulies added a comment - Why is the cache a field? Doesn't this result in suppressing warnings across invocations of the plugin? And if the component strategy prevents that, why not just create it in the shade method? We really should have a test case to go with this.
Hide
Permalink
Robert Burrell Donkin added a comment -

I think this could be best solved by factoring out a MergerTransformer interface. I'm happy to development a fully tested solution if the consensus approves this approach.

Show
Robert Burrell Donkin added a comment - I think this could be best solved by factoring out a MergerTransformer interface. I'm happy to development a fully tested solution if the consensus approves this approach.
Hide
Permalink
Benson Margulies added a comment -

I don't have any problem with fixing the redundant messages on the way to the bigger goal you state. I just question the implementation and mourn the lack of a test.

Show
Benson Margulies added a comment - I don't have any problem with fixing the redundant messages on the way to the bigger goal you state. I just question the implementation and mourn the lack of a test.

People

  • Assignee:
    Unassigned
    Reporter:
    Elisha Ezeugoh
Vote (1)
Watch (1)

Dates

  • Created:
    Updated: