Maven 2.x Shade Plugin

Annotated Method Parameters Not Shaded

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.4
  • Fix Version/s: 1.6
  • Labels:
  • Environment:
    JDK 1.6.0r21
  • Number of attachments :
    1

Description

When shading a function or constructor like

@JsonCreator
public MyClass(@JsonProperty("blah") String blah) {
}

The @JsonProperty annotation is not shaded. I decompiled the resulting .class file and you see '@JsonCreator' is properly shaded, while @JsonProperty is not. This is probably related to MSHADE-79.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Olivier Lamy added a comment -

any sample project to reproduce ?

Show
Olivier Lamy added a comment - any sample project to reproduce ?
Hide
Permalink
Greg Wittel added a comment -

Attached.

It looks like the issue is resolved with the v1.5 plugin (at least in my test). The attached test uses the 1.4 plugin per original bug.

If you do:
$ mvn package
And decompile the shaded Item.class (http://http://java.decompiler.free.fr/) you'll see the 'import' statements look like:

import org.codehaus.jackson.annotate.JsonProperty;
import shade.org.codehaus.jackson.annotate.JsonCreator;

When both classes should have been relocated to the 'shade' namespace.

Show
Greg Wittel added a comment - Attached. It looks like the issue is resolved with the v1.5 plugin (at least in my test). The attached test uses the 1.4 plugin per original bug. If you do: $ mvn package And decompile the shaded Item.class ( http://http://java.decompiler.free.fr/ ) you'll see the 'import' statements look like: import org.codehaus.jackson.annotate.JsonProperty; import shade.org.codehaus.jackson.annotate.JsonCreator; When both classes should have been relocated to the 'shade' namespace.
Hide
Permalink
Greg Wittel added a comment -

Here is the decompiler output from the 1.4 version of the plugin:

"Item.class from 1.4 plugin"
/*    */ package test;
/*    */
/*    */ import org.codehaus.jackson.annotate.JsonProperty;
/*    */ import shade.org.codehaus.jackson.annotate.JsonCreator;
/*    */
/*    */ public class Item
/*    */ {
/*    */   private String somestring;
/*    */
/*    */   @JsonCreator
/*    */   Item(@JsonProperty("blah") String blah)
/*    */   {
/* 15 */     this.somestring = blah;
/*    */   }
/*    */
/*    */   public String getSomestring() {
/* 19 */     return this.somestring;
/*    */   }
/*    */
/*    */   public void setSomestring(String s) {
/* 23 */     this.somestring = s;
/*    */   }
/*    */ }

/* Location:           /tmp/javatest/
 * Qualified Name:     test.Item
 * JD-Core Version:    0.6.0
 */
Show
Greg Wittel added a comment - Here is the decompiler output from the 1.4 version of the plugin: "Item.class from 1.4 plugin" /* */ package test; /* */ /* */ import org.codehaus.jackson.annotate.JsonProperty; /* */ import shade.org.codehaus.jackson.annotate.JsonCreator; /* */ /* */ public class Item /* */ { /* */ private String somestring; /* */ /* */ @JsonCreator /* */ Item(@JsonProperty( "blah" ) String blah) /* */ { /* 15 */ this .somestring = blah; /* */ } /* */ /* */ public String getSomestring() { /* 19 */ return this .somestring; /* */ } /* */ /* */ public void setSomestring( String s) { /* 23 */ this .somestring = s; /* */ } /* */ } /* Location: /tmp/javatest/ * Qualified Name: test.Item * JD-Core Version: 0.6.0 */
Hide
Permalink
Olivier Lamy added a comment -

cool please test with 1.6-SNAPSHOT.
That was probably due to http://forge.ow2.org/tracker/index.php?func=detail&aid=314481&group_id=23&atid=100023.

Show
Olivier Lamy added a comment - cool please test with 1.6-SNAPSHOT. That was probably due to http://forge.ow2.org/tracker/index.php?func=detail&aid=314481&group_id=23&atid=100023 .

People

  • Assignee:
    Olivier Lamy
    Reporter:
    Greg Wittel
Vote (2)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: