Maven 2.x Shade Plugin

Temporary dependency-reduced-pom.xml in basedir causes problems within shared build trees

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.6
  • Fix Version/s: 1.7
  • Labels:
    None
  • Number of attachments :
    0

Description

The runtime dependency-reduced-pom.xml (not the one in outputDirectory) causes problems within a build tree that is shared across multiple machines/builds. This file is cleaned up after it is no longer needed and if more than one build is running shade and the subsequent goals within the same subdirectory at around the same time, the dependency-reduced-pom.xml file can be wiped out by one process while another process still requires it.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MSHADE-23 ${basedir} is wrong after running shade plugin

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Seth Gransky added a comment -

See Dan's comment about the fix commited to resolve MSHADE-23.

Show
Seth Gransky added a comment - See Dan's comment about the fix commited to resolve MSHADE-23 .
Hide
Permalink
Benson Margulies added a comment -

And while here, note that the d-r-p doesn't get along so well if you try to have multiple shade executions, since the name conflicts.

Show
Benson Margulies added a comment - And while here, note that the d-r-p doesn't get along so well if you try to have multiple shade executions, since the name conflicts.
Hide
Permalink
Benson Margulies added a comment -

The problem here is that, to avoid calculating a correct relative path from the desired destination of the drp to wherever the parent is, the code was written to write it out temporarily right in the basedir, where collisions are possible.

The fix I've chosen is to calculate the relative path. An alternative would have been to use a temp file with a unique name in the basedir. In hindsight, that would have been less work.

Show
Benson Margulies added a comment - The problem here is that, to avoid calculating a correct relative path from the desired destination of the drp to wherever the parent is, the code was written to write it out temporarily right in the basedir, where collisions are possible. The fix I've chosen is to calculate the relative path. An alternative would have been to use a temp file with a unique name in the basedir. In hindsight, that would have been less work.

People

  • Assignee:
    Benson Margulies
    Reporter:
    Seth Gransky
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: