Maven 2.x Shade Plugin

Shade ha sissue generating a source jar on linux, and generates an error on Java 7

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Not A Bug
  • Affects Version/s: None
  • Fix Version/s: None
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    1

Description

We are having issues with the shade plugin on Ubuntu, when it works well on mac OSX. Here is how to reproduce the error:

1) svn co http://svn.apache.org/repos/asf/directory/apacheds/trunk-with-dependencies/
2) cd shared
3) mvn clean install -Dmaven.test.skip

On Mac OSX, maven 3.0.3, Java 1.6.0_29, the shared/all/target directory contains :
rw-rr- 1 elecharny staff 8573 Jan 27 16:20 original-shared-all-1.0.0-M10-SNAPSHOT.jar
rw-rr- 1 elecharny staff 2535518 Jan 27 16:21 shared-all-1.0.0-M10-SNAPSHOT-sources.jar
rw-rr- 1 elecharny staff 2643029 Jan 27 16:20 shared-all-1.0.0-M10-SNAPSHOT.jar

All is fine, the shared-all-1.0.0-M10-SNAPSHOT-sources.jar file contains everything we need.

On Ubuntu 11.10, maven 3.0.3, Java 1.6.0_29, running the exact same command, the shared-all-1.0.0-M10-SNAPSHOT-sources.jar contains 0 bytes.

Same but using Java 7 on ubuntu, we now get an error :
Failed to execute goal org.apache.geronimo.genesis.plugins:tools-maven-plugin:1.4:verify-legal-files (verify-legal-files) on project shared-all: Atifact does not contain any legal files: shared-all-1.0.0-M10-SNAPSHOT-sources.jar

We run the following command on Mac OSX, using maven 3.0.3 and Java 1.6.0_29

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benson Margulies added a comment - - edited

I can repro this on MacOSX with maven 3.0.4.

Show
Benson Margulies added a comment - - edited I can repro this on MacOSX with maven 3.0.4.
Hide
Permalink
Benson Margulies added a comment -

I wonder about:

INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.apache.directory.shared:shared-all:jar:1.0.0-M13-SNAPSHOT
[WARNING] 'parent.relativePath' of POM org.apache.directory.shared:shared-parent:1.0.0-M13-SNAPSHOT (/Users/benson/asf/trunk-with-dependencies/shared/pom.xml) points at org.apache.directory.server:apacheds-with-dependencies instead of org.apache.directory.project:project, please verify your project structure @ org.apache.directory.shared:shared-parent:1.0.0-M13-SNAPSHOT, /Users/benson/asf/trunk-with-dependencies/shared/pom.xml, line 22, column 11
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.

Show
Benson Margulies added a comment - I wonder about: INFO] Scanning for projects... [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.directory.shared:shared-all:jar:1.0.0-M13-SNAPSHOT [WARNING] 'parent.relativePath' of POM org.apache.directory.shared:shared-parent:1.0.0-M13-SNAPSHOT (/Users/benson/asf/trunk-with-dependencies/shared/pom.xml) points at org.apache.directory.server:apacheds-with-dependencies instead of org.apache.directory.project:project, please verify your project structure @ org.apache.directory.shared:shared-parent:1.0.0-M13-SNAPSHOT, /Users/benson/asf/trunk-with-dependencies/shared/pom.xml, line 22, column 11 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
Hide
Permalink
Benson Margulies added a comment -

Here's the fix to your tree.

Show
Benson Margulies added a comment - Here's the fix to your tree.
Hide
Permalink
Benson Margulies added a comment -

The problem here is that you never run the sources plugin to build any sources that can be combined by shade. I've attached a fix to this for your tree.

Show
Benson Margulies added a comment - The problem here is that you never run the sources plugin to build any sources that can be combined by shade. I've attached a fix to this for your tree.
Hide
Permalink
Benson Margulies added a comment -

See patch attached for your pom to actually make some sources to combine in shade.

Show
Benson Margulies added a comment - See patch attached for your pom to actually make some sources to combine in shade.
Hide
Permalink
Emmanuel Lécharny added a comment -

Thanks for the patch !

I don't know why we forgot to include the source-plugin in our build. We would have noticed that if we weren't focusing on the fact that the build was allegedly working on Mac OSX...

I have applied the patch, but haven't tested it yet, will do that later.

Show
Emmanuel Lécharny added a comment - Thanks for the patch ! I don't know why we forgot to include the source-plugin in our build. We would have noticed that if we weren't focusing on the fact that the build was allegedly working on Mac OSX... I have applied the patch, but haven't tested it yet, will do that later.

People

  • Assignee:
    Benson Margulies
    Reporter:
    Emmanuel Lécharny
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: